Skip to content

Use pre-computed cell area and volume for Div_par_K_Grad_par #3461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bendudson merged 4 commits into from
Aug 18, 2026
Merged

Use pre-computed cell area and volume for Div_par_K_Grad_par #3461

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4100f88
Adjust parallel diffusion operator for fci
totork Aug 17, 2026
6ba4f1d
Add missing class
totork Aug 17, 2026
3f35c51
Delete brackets
totork Aug 17, 2026
2111e68
Add missing () for dy
totork Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions src/mesh/difops.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,25 +392,20 @@ Field3D Div_par_K_Grad_par_mod_impl(const Field3DParallel& Kin,

// Upper cell edge
const BoutReal c_up = 0.5 * (Kin[i] + K_up[iyp]); // K at the upper boundary
const BoutReal J_up =
0.5 * (coord->J()[i] + coord->J().yup()[iyp]); // Jacobian at boundary
const BoutReal g_22_up = 0.5 * (coord->g_22()[i] + coord->g_22().yup()[iyp]);
const BoutReal gradient_up =
2. * (f_up[iyp] - fin[i]) / (coord->dy()[i] + coord->dy().yup()[iyp]);
(f_up[iyp] - fin[i]) / (coord->dy()[i] * sqrt(coord->g_22_yhigh()[i]));

const BoutReal flux_up = c_up * J_up * gradient_up / g_22_up;
const BoutReal flux_up = c_up * gradient_up * coord->cell_area_yhigh()[i];

// Lower cell edge
const BoutReal c_down = 0.5 * (Kin[i] + K_down[iym]); // K at the lower boundary
const BoutReal J_down =
0.5 * (coord->J()[i] + coord->J().ydown()[iym]); // Jacobian at boundary
const BoutReal g_22_down = 0.5 * (coord->g_22()[i] + coord->g_22().ydown()[iym]);
const BoutReal gradient_down =
2. * (fin[i] - f_down[iym]) / (coord->dy()[i] + coord->dy().ydown()[iym]);
(fin[i] - f_down[iym]) / (coord->dy()[i] * sqrt(coord->g_22_ylow()[i]));

const BoutReal flux_down = c_down * J_down * gradient_down / g_22_down;
const BoutReal flux_down = c_down * gradient_down * coord->cell_area_ylow()[i];

result[i] = (flux_up - flux_down) / (coord->dy()[i] * coord->J()[i]);
// Add the fluxes
result[i] = (flux_up - flux_down) / (coord->cell_volume()[i]);
}

return result;
Expand Down
Loading