Added stats to prune command #9271
Open
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 1.4-maint #9271 +/- ##
=============================================
- Coverage 80.57% 80.53% -0.04%
=============================================
Files 38 38
Lines 11256 11264 +8
Branches 1771 1772 +1
=============================================
+ Hits 9070 9072 +2
- Misses 1616 1623 +7
+ Partials 570 569 -1 ☔ View full report in Codecov by Sentry. |
ThomasWaldmann
requested changes
Jan 25, 2026
Member
ThomasWaldmann
left a comment
ThomasWaldmann
left a comment
There was a problem hiding this comment.
Thanks for the PR, some feedback...
| if args.stats: | ||
| stats_logger = logging.getLogger('borg.output.stats') | ||
| stats_logger.info('Archive counts:') | ||
| stats_logger.info('Number of archives: %d', len(manifest.archives)) |
Member
There was a problem hiding this comment.
that way, the numbers are left-aligned.
guess I'ld prefer either:
- no alignment (simplest)
- right aligned
| stats_logger.info('Number of archives: %d', len(manifest.archives)) | ||
|
|
||
| if args.glob_archives: | ||
| stats_logger.info('Number of archives matching pattern: %d', len(archives_checkpoints)) |
Member
There was a problem hiding this comment.
maybe say "globbing pattern" to be more specific.
| str(cache), | ||
| DASHES, logger=logging.getLogger('borg.output.stats')) | ||
|
|
||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9262
Added a --stats argument to the prune command to display archive counts (total, kept, pruned).