Skip to content

typing: annotate manifest module boundaries and enable strict mypy checks (refs #10021) #10556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Prateek99-s wants to merge 1 commit into
base: master
Choose a base branch
from
Open

typing: annotate manifest module boundaries and enable strict mypy checks (refs #10021) #10556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,13 +175,24 @@ module = [
"msgpack.*",
"llfuse",
"pyfuse3",
"mfusepy",
"trio",
"borghash.*",
"borgstore.*",
"textual.*",
"backports.*",
"borg.crypto.low_level",
"borg.legacy.crypto.low_level",
"borg.platform.*",
]
ignore_missing_imports = true

[[tool.mypy.overrides]]
module = "borg.manifest"
disallow_untyped_defs = true
disallow_incomplete_defs = true
check_untyped_defs = true

[tool.tox]
requires = ["tox>=4.19", "pkgconfig", "cython", "wheel", "setuptools-scm[toml]"]
# Important: when adding/removing Python versions here,
Expand Down
3 changes: 2 additions & 1 deletion src/borg/legacy/archives.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ def list(
archive_infos.reverse()
return archive_infos

def list_considering(self, args):
def list_considering(self, args, *, reverse=False):
"""Get a list of archives, considering --first/last/prefix/match-archives/sort cmdline args."""
name = getattr(args, "name", None)
if name is not None:
Expand All @@ -250,6 +250,7 @@ def list_considering(self, args):
)
return self.list(
sort_by=args.sort_by.split(","),
reverse=reverse,
match=args.match_archives,
first=getattr(args, "first", None),
last=getattr(args, "last", None),
Expand Down
Loading