docs: specify S3-compatible ETag format for single-part and multipart uploads#392
Merged
bootjp merged 2 commits intofeature/s3-compatiblefrom Mar 21, 2026
Merged
docs: specify S3-compatible ETag format for single-part and multipart uploads#392bootjp merged 2 commits intofeature/s3-compatiblefrom
bootjp merged 2 commits intofeature/s3-compatiblefrom
Conversation
…ploads Co-authored-by: bootjp <1306365+bootjp@users.noreply.github.com> Agent-Logs-Url: https://github.com/bootjp/elastickv/sessions/e7aa7963-d972-4405-b25c-afdba2f7b535
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on etag spec in S3-compatible adapter design docs
docs: specify S3-compatible ETag format for single-part and multipart uploads
Mar 21, 2026
bootjp
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The design doc referenced ETag computation without defining the required format, leaving ambiguity that would break S3 client/SDK compatibility for integrity checks and conditional requests.
Changes
PutObject):hex(md5(object_body))CompleteMultipartUpload):hex(md5(md5_bytes(part_1) || ... || md5_bytes(part_N))) + "-N"CompleteMultipartUploadmust validate caller-supplied ETags against stored part descriptors before committing the manifestPutObjectflow step (§7.1) to reference the MD5 computation explicitlyMultipart ETag formula:
where
md5_bytes(part_i)is the raw 16-byte MD5 digest of parti's body.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.