Skip to content

xtask: Drain vendor tar stream to avoid zstd SIGPIPE #2595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeckersb merged 1 commit into from
Oct 28, 2026
Merged

xtask: Drain vendor tar stream to avoid zstd SIGPIPE #2595

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion crates/xtask/src/xtask.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,8 @@ fn vendor_denied_crate(path: &Utf8Path) -> Option<&'static str> {
/// [`VENDOR_DENYLIST`].
fn vendor_denied_entries(archive: impl std::io::Read) -> Result<Vec<String>> {
let mut denied = Vec::new();
for entry in tar::Archive::new(archive).entries()? {
let mut archive = tar::Archive::new(archive);
for entry in archive.entries()? {
let entry = entry?;
let path = entry.path()?;
let path = path.to_string_lossy();
Expand All @@ -542,6 +543,9 @@ fn vendor_denied_entries(archive: impl std::io::Read) -> Result<Vec<String>> {
denied.push(format!("{path} (from {name})"));
}
}
// Drain trailing padding after the end-of-archive marker so the
// writer (zstd) doesn't get SIGPIPE.
std::io::copy(&mut archive.into_inner(), &mut std::io::sink())?;
Ok(denied)
}

Expand Down
Loading