[Rolv-Apneseth]

This avoids writing out fields with null values. See coreos/bootupd#1166.

[Johan-Liebert1]

Personally not a fan of this as ime it ends up being confusing that sometimes we'll have version and sometimes we won't. I think the actual fix should be in bootupd marking version as Option<String>

[Rolv-Apneseth]

Personally not a fan of this as ime it ends up being confusing that sometimes we'll have version and sometimes we won't. I think the actual fix should be in bootupd marking version as Option<String>

I don't have a strong opinion, but that is a common pattern with JSON. I only made this PR due to the conversation in coreos/bootupd#1166, since @cgwalters agreed to the "writer" change. This indeed makes no difference to the actual issue in bootupd.

[Rolv-Apneseth]

Also, https://github.com/bootc-dev/bootc/blob/main/crates/lib/src/install/aleph.rs#L23-L24 and https://github.com/bootc-dev/bootc/blob/main/crates/lib/src/install/aleph.rs#L31-L32 can already be skipped while serializing

[Rolv-Apneseth]

Not too sure what would cause the CI failure on test-integration (centos-9, ostree, xfs, grub, bls, unsealed):

    content: Finalizing filesystem root
    content: Unmounting filesystems
    content: Installation complete!
    content: umount: /var/mnt/composefs-native: target is busy.
    content: Connection to localhost closed.
failures.yaml (/var/tmp/tmt/bootc-tmt-1a7u9jws-tmt-plans-integration-plan-60-install-composefs-native/tmt/plans/integration/plan-60-install-composefs-native/execute/data/guest/default-0/tmt/tests/tests/test-60-install-composefs-native-1/failures.yaml)

[jeckersb]

Not too sure what would cause the CI failure on test-integration (centos-9, ostree, xfs, grub, bls, unsealed):

It flakes sometimes, not sure if it's a code race or some sort of infra issue, but I re-ran it and it should hopefully work on retry 🤞

[Rolv-Apneseth]

Thanks @jeckersb