ostree-ext: Fix warning on rust 1.9.2 #1859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This started warning with:
warning: value assigned to `no_signature_verification` is never read
--> crates/ostree-ext/src/cli.rs:1265:21
|
1265 | mut no_signature_verification,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: maybe it is overwritten before being read?
= note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default
Which is true in this case, we never actually read the pattern-matched
value. Change it to be explicitly unused with '_' and then shadow it
with a `let` binding.
Signed-off-by: John Eckersberg <jeckersb@redhat.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a unused_assignments warning from the Rust compiler. The change is idiomatic, using _ to ignore the unused value from the struct destructuring and then shadowing the variable with a let binding. This is a clean and effective way to resolve the warning. The change is minimal and improves the code by removing the compiler warning. I have no further suggestions.
Collaborator
Author
|
Well, rust 1.92, but I'm not going to retrigger CI on an obvious typo 😄 |
cgwalters
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started warning with:
warning: value assigned to
no_signature_verificationis never read--> crates/ostree-ext/src/cli.rs:1265:21
|
1265 | mut no_signature_verification,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: maybe it is overwritten before being read?
= note:
#[warn(unused_assignments)](part of#[warn(unused)]) on by defaultWhich is true in this case, we never actually read the pattern-matched
value. Change it to be explicitly unused with '_' and then shadow it
with a
letbinding.Signed-off-by: John Eckersberg jeckersb@redhat.com