Repository navigation
Multiple fixes for running the upgrade test on EKS (backport #250) - #260
Merged
Merged
Conversation
Add EKS to the upgrade test provider gate and read E2E_IMAGE_PULL_SECRET to set imagePullSecrets on helm install/upgrade, allowing the test to pull from private registries. Assisted-by: AI Signed-off-by: Alice Frosi <afrosi@redhat.com> (cherry picked from commit 001d698)
Forward RELEASED_OPERATOR_TAG, RELEASED_OPERATOR_IMG, and EKS_IMAGE_PULL_SECRET to the e2e-eks make target so the upgrade test can run against EKS clusters. Assisted-by: AI Signed-off-by: Alice Frosi <afrosi@redhat.com> (cherry picked from commit 6cac27d)
The Konflux build pipeline packages the chart as bootc-operator-chart, causing the Helm fullname template to produce bootc-operator-bootc-operator-chart instead of bootc-operator. Setting nameOverride ensures consistent resource names regardless of the OCI artifact name. Assisted-by: AI Signed-off-by: Alice Frosi <afrosi@redhat.com> (cherry picked from commit bbd939a)
The upgrade test cleanup uses helm upgrade to restore the operator after the test. If the test fails during uninstall (e.g. CRD deletion timeout), the Helm release no longer exists and a plain helm upgrade fails, leaving the operator down for subsequent tests. Adding --install allows the cleanup to recover from a fully uninstalled state, preventing cascading failures. Assisted-by: AI Signed-off-by: Alice Frosi <afrosi@redhat.com> (cherry picked from commit e5747f1)
Run helm dependency build before helm install so the CRDs subchart is available. Update uninstallOperator comment to reflect that CRDs are removed together with the main release. Assisted-by: AI Signed-off-by: Alice Frosi <afrosi@redhat.com> (cherry picked from commit ac037fe)
On EKS, bootc status reports the platform-specific content digest in ImageDigest and the manifest-list digest in the Image pullspec. The direct ImageDigest check fails when these differ. Use the imageMatchesDigest helper which accepts both, matching what the controller does via InfoMatchesDigest. Assisted-by: AI Signed-off-by: Alice Frosi <afrosi@redhat.com> (cherry picked from commit d259ae5)
On EKS CI, the Konflux pipeline publishes the operator and CRDs as separate OCI Helm charts. The deploy script (test_deploy.py) installs them as two independent releases: bootc-operator-crds and bootc-operator (with crds.install=false). The upgrade test only ran helm uninstall on the main release, leaving the CRDs behind and timing out waiting for them to be deleted. Check whether a standalone CRDs release exists before uninstalling. On bink (where CRDs are bundled as a subchart in a single release) the check returns false and the extra uninstall is skipped. Assisted-by: AI Signed-off-by: Alice Frosi <afrosi@redhat.com> (cherry picked from commit f998392)
alicefr
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several fixes required for running the test
TestOperatorUpgradeon EKSThis is an automatic backport of pull request #250 done by Mergify.