Skip to content

Cleanup superflous Boost headers - #164

Merged
mborland merged 8 commits into
boostorg:developfrom
Flamefire:stdint
Sep 13, 2026
Merged

mborland merged 8 commits into
boostorg:developfrom
Flamefire:stdint

Conversation

@Flamefire

Copy link
Copy Markdown
Contributor

In most cases std::uint32_t etc and in all cases std::numeric_limits is used.

So include the standard headers and replace the remaining Boost type usages

@codecov

codecov Bot commented Sep 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.88889% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.79%. Comparing base (21b0544) to head (9bb4d0c).

Files with missing lines Patch % Lines
include/boost/random/detail/seed_impl.hpp 44.44% 5 Missing ⚠️
include/boost/random/detail/large_arithmetic.hpp 78.57% 3 Missing ⚠️
include/boost/random/shuffle_order.hpp 50.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #164   +/-   ##
========================================
  Coverage    95.79%   95.79%           
========================================
  Files          117      117           
  Lines         7660     7660           
========================================
  Hits          7338     7338           
  Misses         322      322           
Files with missing lines Coverage Δ
include/boost/random/additive_combine.hpp 100.00% <100.00%> (ø)
include/boost/random/binomial_distribution.hpp 97.84% <ø> (ø)
include/boost/random/cauchy_distribution.hpp 92.68% <ø> (ø)
include/boost/random/chi_squared_distribution.hpp 100.00% <ø> (ø)
include/boost/random/detail/const_mod.hpp 100.00% <100.00%> (ø)
include/boost/random/detail/gray_coded_qrng.hpp 92.15% <ø> (ø)
include/boost/random/detail/int_float_pair.hpp 95.23% <ø> (ø)
include/boost/random/detail/integer_log2.hpp 100.00% <ø> (ø)
include/boost/random/detail/polynomial.hpp 96.93% <100.00%> (ø)
include/boost/random/detail/qrng_base.hpp 95.89% <100.00%> (ø)
... and 55 more

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21b0544...9bb4d0c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mborland mborland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I need to look more closely at the rest of the dependencies in this lib. I'm sure almost all can go away.

@mborland
mborland merged commit 5b77674 into boostorg:develop Sep 13, 2026
62 of 63 checks passed
@Flamefire

Copy link
Copy Markdown
Contributor Author

Given the amount of C++11 features already required I guess that allows dropping more, e.g. Boost.bind

Note that this library is still very valuable: C++11 does not define how distributions work (e.g. how many calls to the RNG occur) and how distributions and generators are serialized.
That's a big advantage of this implementation: It can be used where reproducible portability is required.

@Flamefire
Flamefire deleted the stdint branch September 13, 2026 16:23
@mborland

mborland commented Sep 13, 2026

Copy link
Copy Markdown
Member

Given the amount of C++11 features already required I guess that allows dropping more, e.g. Boost.bind

One of the dependencies is Math so we're at least up to C++14 here.

Note that this library is still very valuable: C++11 does not define how distributions work (e.g. how many calls to the RNG occur) and how distributions and generators are serialized. That's a big advantage of this implementation: It can be used where reproducible portability is required.

For sure. We also have newer components with better properties than those offered by <random>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants