Repository navigation
doc: troubleshooting: say what a virtual_ptr parameter may be - #140
Merged
Merged
Conversation
The entry for "virtual_ptr<> must be passed by value or by const reference" began "A method takes a virtual_ptr by non-const lvalue reference", stating as fact what the library refuses. It now names the declarations that produce the message, and the rule: by value or by const reference. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #140 +/- ##
========================================
Coverage 92.56% 92.57%
========================================
Files 29 29
Lines 2314 2316 +2
Branches 699 699
========================================
+ Hits 2142 2144 +2
Misses 111 111
Partials 61 61 Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Written by Claude Code, on behalf of @jll63.)
The troubleshooting entry for
virtual_ptr<> must be passed by value or by const referencebegan "A method takes avirtual_ptrby non-const lvalue reference, or by rvalue reference". That states as a fact something the library refuses.It now names the declarations that produce the message,
virtual_ptr<Node>&andvirtual_ptr<Node>&&, and then states the rule: a method takes avirtual_ptrby value, which is cheap, or by const reference.The docs build without warnings on the page, and the row renders with all five code spans formatted.
🤖 Generated with Claude Code