Skip to content

Replace CONFIGURE_DEPENDS with BOOST_CONFIGURE_DEPENDS - #138

Merged
jll63 merged 1 commit into
boostorg:developfrom
cdglove:develop
Nov 3, 2026
Merged

jll63 merged 1 commit into
boostorg:developfrom
cdglove:develop

Conversation

@cdglove

@cdglove cdglove commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

When file(GLOB ... CONFIGURE_DEPENDS) or file(GLOB_RECURSE ... CONFIGURE_DEPENDS) is evaluated, CMake's make style generators create a verification script (VerifyGlobs.cmake) that gets run on every build, outputting "Re-checking globbed directories....". This can cause a a noticeable delay on incremental builds.

Since the headers are only needed for IDE project navigation, limiting this check to that use case is a good compromise.

@cdglove
cdglove requested a review from jll63 as a code owner October 30, 2026 11:19
@cppalliance-bot

cppalliance-bot commented Oct 30, 2026 •

Copy link
Copy Markdown

An automated preview of the documentation is available at https://138.openmethod.prtest3.cppalliance.org/libs/openmethod/doc/html/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-10-31 22:17:17 UTC

@sehe

sehe commented Oct 30, 2026

Copy link
Copy Markdown

I asked a question about the validity of the reasoning here boostorg/assert#49 (comment)

Allows projects building boost via add_subdirectory to avoid the cost
of GLOB on every build.
@cdglove cdglove changed the title Only GLOB headers when generating Visual Studio projects Replace CONFIGURE_DEPENDS with BOOST_CONFIGURE_DEPENDS Oct 31, 2026
@cdglove

cdglove commented Nov 1, 2026

Copy link
Copy Markdown
Contributor Author

Updated as per discussion on the mailing list and integrated into the assert library.

https://lists.boost.org/archives/list/boost@lists.boost.org/thread/LKPFNC3AMPIVWRAE75EFMYRMS6AL6MV4/

boostorg/assert#49

@codecov

codecov Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.57%. Comparing base (b681217) to head (c4ca9ae).
⚠️ Report is 11 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #138   +/-   ##
========================================
  Coverage    92.56%   92.57%           
========================================
  Files           29       29           
  Lines         2314     2316    +2     
  Branches       699      699           
========================================
+ Hits          2142     2144    +2     
  Misses         111      111           
  Partials        61       61           

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 071049a...c4ca9ae. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jll63
jll63 merged commit 18bd66f into boostorg:develop Nov 3, 2026
56 of 57 checks passed
@jll63 jll63 linked an issue Nov 3, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configuring with CMake < 3.16 fails

4 participants