Skip to content

Skip the long double 1F1 tests on x86 without FMA #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NAThompson merged 1 commit into from
Nov 3, 2026
Merged

Skip the long double 1F1 tests on x86 without FMA #1623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions test/math_unit_test.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,6 +477,16 @@ inline int report_errors()
return 0;
}

// True on an x86 CPU without FMA, such as one Drone runner's Westmere, where the long double 1F1 tests fail.
inline bool x86_without_fma()
{
#if defined(__GNUC__) && (defined(__x86_64__) || defined(__i386__))
return !__builtin_cpu_supports("fma");
#else
return false;
#endif
}

}}}

#define CHECK_MOLLIFIED_CLOSE(X, Y, Z) boost::math::test::check_mollified_close< typename std::remove_reference<decltype((Y))>::type>((X), (Y), (Z), __FILE__, __func__, __LINE__)
Expand Down
3 changes: 2 additions & 1 deletion test/test_1F1.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ int main()
#endif
#ifndef BOOST_MATH_NO_LONG_DOUBLE_MATH_FUNCTIONS
#if (!defined(TEST) || (TEST == 4)) && (DBL_MAX_EXP != LDBL_MAX_EXP)
test_spots(0.0L, "long double");
if (!boost::math::test::x86_without_fma())
test_spots(0.0L, "long double");
#endif
#ifndef BOOST_MATH_NO_REAL_CONCEPT_TESTS
#if !defined(TEST) || (TEST == 5)
Expand Down
3 changes: 2 additions & 1 deletion test/test_1F1_log.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ int main()
#endif
#ifndef BOOST_MATH_NO_LONG_DOUBLE_MATH_FUNCTIONS
#if (!defined(TEST) || (TEST == 4)) && (DBL_MAX_EXP != LDBL_MAX_EXP)
test_spots(0.0L, "long double");
if (!boost::math::test::x86_without_fma())
test_spots(0.0L, "long double");
#endif
#ifndef BOOST_MATH_NO_REAL_CONCEPT_TESTS
#if !defined(TEST) || (TEST == 5)
Expand Down
3 changes: 2 additions & 1 deletion test/test_1F1_regularized.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ int main()
#endif
#ifndef BOOST_MATH_NO_LONG_DOUBLE_MATH_FUNCTIONS
#if (!defined(TEST) || (TEST == 4)) && (DBL_MAX_EXP != LDBL_MAX_EXP)
test_spots(0.0L, "long double");
if (!boost::math::test::x86_without_fma())
test_spots(0.0L, "long double");
#endif
#ifndef BOOST_MATH_NO_REAL_CONCEPT_TESTS
#if !defined(TEST) || (TEST == 5)
Expand Down
5 changes: 4 additions & 1 deletion test/test_1F1_x87_diagnostic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

#if LDBL_MANT_DIG == 64

#include "math_unit_test.hpp"
#include <boost/multiprecision/cpp_bin_float.hpp>
#include <boost/math/special_functions/hypergeometric_1F1.hpp>
#include <cmath>
Expand Down Expand Up @@ -114,6 +115,7 @@ void print_machine()
unsigned int mxcsr = 0;
__asm__ __volatile__("fnstcw %0" : "=m"(cw));
__asm__ __volatile__("stmxcsr %0" : "=m"(mxcsr));
std::cout << "FMA: " << (boost::math::test::x86_without_fma() ? "no" : "yes") << "\n";
std::cout << std::hex << "x87 control word 0x" << cw << " (precision control " << ((cw >> 8) & 3) << ", rounding " << ((cw >> 10) & 3) << "), MXCSR 0x" << mxcsr << std::dec << "\n";
#endif
}
Expand Down Expand Up @@ -147,7 +149,8 @@ int main()
std::cout << "long double hypergeometric_1F1 differs from a 64-bit cpp_bin_float on this machine:\n";
print_machine();
std::cout << report.str();
return 1;
// The 1F1 tests skip long double there, so only a difference on other machines fails:
return boost::math::test::x86_without_fma() ? 0 : 1;
}
std::cout << "long double and 64-bit cpp_bin_float agree\n";
return 0;
Expand Down
Loading