Skip to content

Fix issue 1463 - #1464

Merged
NAThompson merged 2 commits into
developfrom
issue1463
Sep 16, 2026
Merged

NAThompson merged 2 commits into
developfrom
issue1463

Conversation

@NAThompson

Copy link
Copy Markdown
Collaborator

No description provided.

@NAThompson

Copy link
Copy Markdown
Collaborator Author

@dschmitz89: I should have a fix in a minute-just submitted a failing unit test first because my clang is broken locally.

Closes #1463

@NAThompson

Copy link
Copy Markdown
Collaborator Author

Build from commit 1 fails with:

====== BEGIN OUTPUT ======
Running 1 test case...
Tests run with GNU C++ version 12.3.0, GNU libstdc++ version 20230510, linux
Testing spot values with type float (Tolerance = 1.19209e-05%).
libs/math/test/test_nc_f.cpp(341): error: in "test_main": difference{3.40282e+38} between P + Q{0} and RealType(1){1} exceeds 0.00119209%
libs/math/test/test_nc_f.cpp(341): error: in "test_main": difference{3.40282e+38} between P + Q{0} and RealType(1){1} exceeds 0.00119209%
libs/math/test/test_nc_f.cpp(341): error: in "test_main": difference{3.40282e+38} between P + Q{0} and RealType(1){1} exceeds 0.00119209%
libs/math/test/test_nc_f.cpp(341): error: in "test_main": difference{3.40282e+38} between P + Q{0} and RealType(1){1} exceeds 0.00119209%
Testing spot values with type double (Tolerance = 2.22045e-14%).
libs/math/test/test_nc_f.cpp(341): error: in "test_main": difference{1.79769e+308} between P + Q{0} and RealType(1){1} exceeds 0.0001%
libs/math/test/test_nc_f.cpp(341): error: in "test_main": difference{1.79769e+308} between P + Q{0} and RealType(1){1} exceeds 0.0001%
libs/math/test/test_nc_f.cpp(341): error: in "test_main": difference{1.79769e+308} between P + Q{0} and RealType(1){1} exceeds 0.0001%
libs/math/test/test_nc_f.cpp(341): error: in "test_main": difference{1.79769e+308} between P + Q{0} and RealType(1){1} exceeds 0.0001%
Testing spot values with type long double (Tolerance = 1.0842e-17%).
libs/math/test/test_nc_f.cpp(341): error: in "test_main": difference{1.18973e+4932} between P + Q{0} and RealType(1){1} exceeds 0.0001%
libs/math/test/test_nc_f.cpp(341): error: in "test_main": difference{1.18973e+4932} between P + Q{0} and RealType(1){1} exceeds 0.0001%
libs/math/test/test_nc_f.cpp(341): error: in "test_main": difference{1.18973e+4932} between P + Q{0} and RealType(1){1} exceeds 0.0001%
libs/math/test/test_nc_f.cpp(341): error: in "test_main": difference{1.18973e+4932} between P + Q{0} and RealType(1){1} exceeds 0.0001%

*** 12 failures are detected in the test module "Master Test Suite"

@NAThompson

Copy link
Copy Markdown
Collaborator Author

@mborland : I think this fix is pretty trivial but do you wanna set your Fable on it?

@NAThompson
NAThompson merged commit 0337ee3 into develop Sep 16, 2026
74 of 76 checks passed
@NAThompson
NAThompson deleted the issue1463 branch September 16, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant