fix: fix smart ptr and broken mpich noble package - #48
Merged
jeremy-murphy merged 3 commits intoSep 3, 2026
Conversation
Becheler
changed the title
Becheler
changed the title
jeremy-murphy
approved these changes
Sep 1, 2026
jeremy-murphy
left a comment
jeremy-murphy
left a comment
Contributor
There was a problem hiding this comment.
Made one request, but it's not strictly required.
Comment on lines
+30
to
+34
| - name: Fix noble mpich (LP 2072338) | ||
| if: matrix.mpi == 'mpich' | ||
| run: | | ||
| wget -q https://launchpad.net/ubuntu/+source/mpich/4.2.0-5.1/+build/28285882/+files/libmpich12_4.2.0-5.1_amd64.deb https://launchpad.net/ubuntu/+source/mpich/4.2.0-5.1/+build/28285882/+files/libmpich-dev_4.2.0-5.1_amd64.deb https://launchpad.net/ubuntu/+source/mpich/4.2.0-5.1/+build/28285882/+files/mpich_4.2.0-5.1_amd64.deb | ||
| sudo dpkg -i libmpich12_4.2.0-5.1_amd64.deb libmpich-dev_4.2.0-5.1_amd64.deb mpich_4.2.0-5.1_amd64.deb |
Contributor
There was a problem hiding this comment.
This configuration runs on ubuntu-latest but this workaround is specific to 24.04 LTS, right? So I'm just concerned that when latest magically becomes 26.04, this will fail. Ideally, I would like this workaround to be conditional on the Ubuntu version, but I'm OK with it being unconditional and we just revert it when necessary.
Contributor
Author
There was a problem hiding this comment.
@jeremy-murphy you're correct, it's now filtered on the OS version 😄
If you agree with the changes, I don't have merge rights with PBGL so you will have to merge yourself 😄
jeremy-murphy
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 1: Smart ptr fix
scalable_rmat_iterator::gen(distributed/rmat_graph_generator.hpp) was declaredboost::shared_ptr<uniform_01<...>>, butboost::generate_edgenow takesstd::shared_ptr<uniform_01<...>>.The mismatch breaks the two TUs that instantiate the iterator :
distributed_rmat_cc_psdistributed_rmat_pagerank.distributed_rmat_ccuses the sequential iterator and is unaffected.This PR changes the member to
std::shared_ptrand add#include <memory>.This matches the sequential rmat iterators in Boost.Graph, which were modernized to
std::shared_ptr.Commit 2: CI fix for Noble broken package mpich
After first commit CI was red for some jobs related to mpich. It happens that there is a known bug with a broken package on Noble distributions: https://bugs.launchpad.net/ubuntu/+source/mpich/+bug/2072338
The quickest fix was to patch the CI for the noble job: (if: matrix.mpi == 'mpich'), it force-installs the 4.2.0-5.1 mpich debs from Launchpad over noble's broken package before the build as described in https://bugs.launchpad.net/ubuntu/+source/mpich/+bug/2072338/comments/14