Skip to content

refactor: align template and typedef types as per convention - #582

Merged
Becheler merged 1 commit into
boostorg:developfrom
andreacassioli:align-type-naming-rcsp
Sep 1, 2026
Merged

refactor: align template and typedef types as per convention#582
Becheler merged 1 commit into
boostorg:developfrom
andreacassioli:align-type-naming-rcsp

Conversation

@andreacassioli

@andreacassioli andreacassioli commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Before submitting

  • This PR targets the develop branch.
  • I searched for an existing PR or issue covering the same change.
  • My contribution is licensed under the Boost Software License 1.0.

Type of change

  • Bug fix
  • New feature or API addition
  • Refactor (no behavior change)
  • Documentation
  • Build, CI, or tooling
  • Other (specify below)

Does this PR introduce a breaking change?

  • Yes (describe migration impact below)
  • No

What this PR does

  • rename template parameter types as pascal case
  • rename some typedef types as snake case.
  • update docs
  • NO logic changes, pure renaming

Motivation

I would like to help modernizing the RCSP code, and I noticed that the naming does not match the convention. It is a small first step in make the code easier to read and more modern.

Testing

Checklist

  • Existing tests pass (b2 in the test/ directory).
  • New behavior is covered by a test, or this is a docs / build / refactor change.
  • Documentation was updated if user-facing behavior changed.
  • No new compiler warnings on the platforms I built against.

@Becheler Becheler self-assigned this Aug 31, 2026
@Becheler Becheler added the docs label Aug 31, 2026
@cppalliance-bot

Copy link
Copy Markdown

An automated preview of the documentation is available at https://582.graph.prtest3.cppalliance.org/libs/graph/doc/html/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-08-31 19:00:16 UTC

@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown

Boost dependency footprint vs develop (auto-generated).
PR run 33427710170 vs develop run 33416903105 (f036dd443e).

Header-inclusion weights (graph files pulling each direct dependency in):

No header-inclusion-weight changes.

Transitive Boost modules: 66 → 66 (0)

@github-actions

Copy link
Copy Markdown

Compiler-warning counts vs develop (auto-generated).
PR run 33427710174 vs develop run 33416903022 (f036dd443e).

Job Baseline After Delta
macos (clang, 14) 648 648 0
macos (clang, 17) 611 611 0
macos (clang, 20) 611 611 0
ubuntu (clang-19, 14) 648 648 0
ubuntu (clang-19, 17) 611 611 0
ubuntu (clang-19, 20) 611 611 0
ubuntu (clang-19, 23) 611 611 0
ubuntu (gcc-14, 14) 801 801 0
ubuntu (gcc-14, 17) 937 937 0
ubuntu (gcc-14, 20) 937 937 0
ubuntu (gcc-14, 23) 937 937 0
windows_msvc_14_3 (msvc-14.3) 961 961 0

@andreacassioli
andreacassioli marked this pull request as ready for review September 1, 2026 15:21
@Becheler

Becheler commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Thank you @andreacassioli for this nice renaming ! 🥳
If this is good for you, I can merge it !

PS: If you are looking for another modernization PR, there is a C++11 guard somewhere in this code:

#if defined(BOOST_NO_CXX11_ALLOCATOR)

given we are C++14 that block can disappear 🎉

@Becheler Becheler changed the title align template and typedef types as per convention refactor: align template and typedef types as per convention Sep 1, 2026
@andrea-cassioli-maersk

Copy link
Copy Markdown
Contributor

Thank you @andreacassioli for this nice renaming ! 🥳 If this is good for you, I can merge it !

PS: If you are looking for another modernization PR, there is a C++11 guard somewhere in this code:

#if defined(BOOST_NO_CXX11_ALLOCATOR)

given we are C++14 that block can disappear 🎉

Good with me!

I will make few more modernization when I have time (there also few more things like use using that can be done to the code!)

@Becheler
Becheler merged commit 5766566 into boostorg:develop Sep 1, 2026
32 checks passed
@jeremy-murphy

Copy link
Copy Markdown
Collaborator

Thanks for the improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants