remove BOOST_GRAPH_EVENT_STUB - #573
Open
Becheler wants to merge 1 commit into
Open
Conversation
|
Boost dependency footprint vs Header-inclusion weights (graph files pulling each direct dependency in): No header-inclusion-weight changes. Transitive Boost modules: 66 → 66 (0) |
|
Compiler-warning counts vs
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting
developbranch.Type of change
Does this PR introduce a breaking change?
What this PR does
Remove
BOOST_GRAPH_EVENT_STUButility.Motivation
BOOST_GRAPH_EVENT_STUBgenerates fluentdo_on_xxx()builder methods onbfs_visitor,dfs_visitorandmas_visitor. Douglas Gregor added it during his postdoc in 2003 (SVN r18853) as a pre-lambda way to attach a bare function object to an event point. The problem it solved no longer exists, the feature was never adopted, and it now stands in the way of the namespace migration:This is also how the issue surfaced: while moving visitor classes from namespace
boosttoboost::graphinmaximum_adjacency_search.hpp, the macro's unqualifieddetail::functor_to_visitorlookup started resolving intoboost::graph::detail(declared in 20+ BGL headers since 2005) instead ofboost::detail, failing with error: 'functor_to_visitor' is not a member of 'boost::graph::detail'. The macro could be fixed by fully qualifying the name, but that would mean patching and then maintaining an API that has had no documented user in 22 years. Deleting it is much cheaper/healthier.Testing
Checklist
b2in thetest/directory).