Merged
Conversation
Owner
Author
Stack
Managed by gh-stack |
There was a problem hiding this comment.
Pull request overview
This PR adds the --version flag to the help output and ensures it always exits with code 0, even when version detection fails. The changes prevent confusing parse errors by making --version consistently terminate the program.
Changes:
- Modified
--versionhandling to always callprocess.exit(0), even when version detection fails - Added
--versionto the help text options schema with description "Show version number" - Updated comment to reflect that built-in options (not just completion-script) are being added
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merged
Also fixes --version to always exit (with code 0) even when version detection fails, preventing confusing parse errors. Note: Testing --version/--help behavior is intentionally excluded from coverage as these paths call process.exit().
d73ff0e to
5339a3c
Compare
- Add --help to help output for consistency with --version - Print 'Version information not available' when version detection fails
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
boneskull
added a commit
that referenced
this pull request
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixes --version to always exit (with code 0) even when version
detection fails, preventing confusing parse errors.
Note: Testing --version/--help behavior is intentionally excluded from
coverage as these paths call process.exit().