Repository navigation
Conversation
|
@coderabbitai full review |
There was a problem hiding this comment.
bompus has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
@cubic review |
@bompus cubic can't start this review because your workspace has reached its free monthly review limit. cubic has reviewed 40,438 of the 40,000 allowed lines of code this month. Reviews resume on 11 November 2026 (in 23 days). Paid plans include much higher monthly review limits. Upgrade now to resume reviews. To help optimise your usage, you can tune cubic to get the most out of your usage limits:
|
✅ Action performedFull review finished. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⚪ Not assessed Merge Risk: ⚪ Minimal · up to
|
Adds two paragraphs to
hr-benchmarkingabout where a slow or timing-out test suite's time actually goes, with changelog entries.Total the per-file startup first. In one suite of 754 test files, the startup each file paid summed to 205 s. Running without per-file isolation (
--no-isolate) saved only 11 s and broke 12 files, so tuning individual slow files would have targeted the wrong cost.Read CI's own passing-run durations before reproducing a CI timeout. In bompus/codegraph#537, two tests took 2.0 to 2.5 s and 2.8 to 11.6 s in passing Windows CI runs. On a desktop they took 1.5 s and 2.5 s. Twenty local runs, ten of them pinned to 4 cores with the affinity verified, gave 0 failures. The runner was honestly slow, not hung, and only its own durations showed it.
The skill text names no project or figures; the figures above are the evidence.
Checks:
bun run checkexit 0,bun test597 tests, 0 failed (8 skipped). A local reviewer pass found one unclear reference ("that comparison"), now "those durations"; it found no contradiction with the Actions procedure's timeout guidance or the affinity notes inreferences/tools.md.Summary by cubic
Adds two diagnostics to
hr-benchmarkingfor slow test suites, with changelog entries.--no-isolatesaved only 11 s.Written for commit 7a121fa. Summary will update on new commits.
Summary by CodeRabbit