Skip to content

docs(hr-benchmarking): total per-file test startup and read CI's own durations before tuning - #401

Closed
bompus wants to merge 3 commits into
mainfrom
docs/bench-test-startup
Closed

bompus wants to merge 3 commits into
mainfrom
docs/bench-test-startup

Conversation

@bompus

@bompus bompus commented Oct 19, 2026 •

Copy link
Copy Markdown
Owner

Adds two paragraphs to hr-benchmarking about where a slow or timing-out test suite's time actually goes, with changelog entries.

Total the per-file startup first. In one suite of 754 test files, the startup each file paid summed to 205 s. Running without per-file isolation (--no-isolate) saved only 11 s and broke 12 files, so tuning individual slow files would have targeted the wrong cost.

Read CI's own passing-run durations before reproducing a CI timeout. In bompus/codegraph#537, two tests took 2.0 to 2.5 s and 2.8 to 11.6 s in passing Windows CI runs. On a desktop they took 1.5 s and 2.5 s. Twenty local runs, ten of them pinned to 4 cores with the affinity verified, gave 0 failures. The runner was honestly slow, not hung, and only its own durations showed it.

The skill text names no project or figures; the figures above are the evidence.

Checks: bun run check exit 0, bun test 597 tests, 0 failed (8 skipped). A local reviewer pass found one unclear reference ("that comparison"), now "those durations"; it found no contradiction with the Actions procedure's timeout guidance or the affinity notes in references/tools.md.


Summary by cubic

Adds two diagnostics to hr-benchmarking for slow test suites, with changelog entries.

  • Before splitting or tuning slow files, total the startup time each test file pays; in one suite that startup summed to 205 s and --no-isolate saved only 11 s.
  • Before reproducing a CI timeout locally, read the per-test durations from CI's own passing runs, which can show honest runner slowness that a desktop won't reproduce even when limited to the runner's core count.

Written for commit 7a121fa. Summary will update on new commits.

View guided diff Turn on auto-fix

Summary by CodeRabbit

  • Documentation
    • Added guidance for investigating slow tests, including checking per-file startup costs and CI test durations before making changes or reproducing timeouts.
    • Clarified when to raise platform test deadlines.

@bompus

bompus commented Oct 19, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai full review

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bompus has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@bompus

bompus commented Oct 19, 2026

Copy link
Copy Markdown
Owner Author

@cubic review

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 19, 2026

Copy link
Copy Markdown

@cubic review

@bompus cubic can't start this review because your workspace has reached its free monthly review limit. cubic has reviewed 40,438 of the 40,000 allowed lines of code this month. Reviews resume on 11 November 2026 (in 23 days). Paid plans include much higher monthly review limits. Upgrade now to resume reviews.

To help optimise your usage, you can tune cubic to get the most out of your usage limits:

Learn more →

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 17024546-9cbe-446a-9780-9637f10f1729
📥 Commits

Reviewing files that changed from the base of the PR and between 4dac802 and 7a121fa.

📒 Files selected for processing: 2
  • CHANGELOG.md
  • skills/hr-benchmarking/SKILL.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The benchmarking skill and Unreleased changelog add guidance to measure per-file startup costs, review passing CI test durations before reproducing timeouts locally, and raise test deadlines only when durations indicate slow tests rather than hangs.

Changes: Slow Test Benchmarking Guidance

Layer / File(s) Summary
Benchmarking guidance and changelog
skills/hr-benchmarking/SKILL.md, CHANGELOG.md
The skill guidance and changelog cover per-file startup costs, passing CI test durations, and when to raise platform test deadlines.

Priority: ⚪ Not assessed

Merge Risk: ⚪ Minimal · up to 7a121

The PR adds benchmarking guidance and matching changelog entries. The deadline recommendation is actionable using passing CI durations, and no unresolved merge risk remains.

### Architecture Summary

Architecture risk: 🔵 Low · up to 7a121

The change affects 2 systems.

Changed systems: CHANGELOG.md, skills

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — CHANGELOG.md (service) was modified; 1 changed file maps to changed impact.
  • observed — skills (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in CHANGELOG.md: Added two hr-benchmarking changelog entries: measure test-file startup overhead before tuning slow files, and use passing CI run durations to assess local timeout reproduction; raise test deadlines only when the durations indicate slowness rather than a hang.
  • observed — Modified behavior in skills/hr-benchmarking/SKILL.md: Added guidance to account for per-file startup time before tuning a slow test suite, consult passing CI run durations before reproducing timeouts locally, and raise platform deadlines only when those durations show tests are slow rather than hung.
Pre-merge checks: Passed 6
Check name Status Explanation
Title check Passed The title clearly identifies both primary documentation changes: measuring per-file test startup time and reviewing CI durations before tuning tests.
Description check Passed The description explains what changed and why, provides supporting evidence, records validation results, and confirms the required changelog and naming constraints. The required checklist items are pr…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Suppressions Explained Passed PASS. The pull request changes only CHANGELOG.md and skills/hr-benchmarking/SKILL.md, adding documentation paragraphs. No changed line adds or broadens a lint, type-check, formatter, or ignore dir…
Rule Changes Documented Passed The diff modifies only skills/hr-benchmarking/SKILL.md and CHANGELOG.md. CHANGELOG.md contains two matching hr-benchmarking entries under ## Unreleased. No modifier or skill is added, remove…
Full details: Description check

Explanation

The description explains what changed and why, provides supporting evidence, records validation results, and confirms the required changelog and naming constraints. The required checklist items are present, although they are shown as unchecked.

Full details: Suppressions Explained

Explanation

PASS. The pull request changes only CHANGELOG.md and skills/hr-benchmarking/SKILL.md, adding documentation paragraphs. No changed line adds or broadens a lint, type-check, formatter, or ignore directive, and no lint or formatter configuration file changes.

Full details: Rule Changes Documented

Explanation

The diff modifies only skills/hr-benchmarking/SKILL.md and CHANGELOG.md. CHANGELOG.md contains two matching hr-benchmarking entries under ## Unreleased. No modifier or skill is added, removed, or renamed, so no README.md table update is required.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bompus bompus closed this Oct 19, 2026
@bompus
bompus deleted the docs/bench-test-startup branch October 19, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant