Skip to content

Implement basic DOM creation - #53

Open
cowboyd wants to merge 1 commit into
mainfrom
dom-basic-creation
Open

cowboyd wants to merge 1 commit into
mainfrom
dom-basic-creation

Conversation

@cowboyd

@cowboyd cowboyd commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Climb the very first rung on the ladder with the 61 adapted cases from Document-createTextNode.html, Document-createElement.html, and Document-createComment.html, enabled in wpt.config.ts.

Implement element, text, and comment creation with string conversion, element name validation, ASCII-only HTML casing, and node ownership and metadata.

Type of change

  • Bug fix
  • Feature
  • Refactor (no behavior change)
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

  • All tests pass (pnpm test)
  • Files are formatted (pnpm format)
  • I have added/updated tests for my changes (if applicable)
  • I have added a changeset

AI-generated code disclosure

  • This PR includes AI-generated code

@pkg-pr-new

pkg-pr-new Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/bombshell-dev/ui/@clack/ui@53

commit: 6fb48d8

@cowboyd
cowboyd force-pushed the wpt-suite-fixes branch 2 times, most recently from 38abe65 to c24229f Compare November 10, 2026 19:39
@codspeed

codspeed Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 240 untouched benchmarks


Comparing dom-basic-creation (6fb48d8) with main (6f7ed0d)

Open in CodSpeed

@codspeed

codspeed Bot commented Nov 10, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 2.61%

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 238 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Memory evergreen (500) 262 KB 391.1 KB -33.01%
⚡ Memory grass (100) 46.9 KB 33.1 KB +41.57%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing dom-basic-creation (2a98c55) with wpt-suite-fixes (c24229f)

Open in CodSpeed

@cowboyd
cowboyd added this pull request to stack #54 November 10, 2026 23:03
Base automatically changed from wpt-suite-fixes to main November 11, 2026 02:58
@cowboyd
cowboyd removed this pull request from stack #54 November 11, 2026 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant