Skip to content

fix(format): apply shared ignore patterns outside tools - #64

Open
dreyfus92 wants to merge 2 commits into
mainfrom
fix/format-ignore-patterns
Open

dreyfus92 wants to merge 2 commits into
mainfrom
fix/format-ignore-patterns

Conversation

@dreyfus92

Copy link
Copy Markdown
Member

bsh format passes tools' own oxfmtrc.json with -c, and oxfmt resolves ignorePatterns relative to the config file, so the *.json, *.md, *.yml and *.jsonc ignores only applied inside tools. in other repos those files were still formatted, or flagged by --check. now format reads ignorePatterns from the shared config and passes each one as a ! exclude.

added a test that runs bsh format --list-different against a fixture with one file per ignored type and checks only the ts file gets listed, it fails on main without the fix.

heads up: once released, the [ci] format bot stops touching json, md and yml files in repos using tools.

@changeset-bot

changeset-bot Bot commented Sep 15, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1709539

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bomb.sh/tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Sep 15, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@bomb.sh/tools@64

commit: 1709539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant