Skip to content

fix(test): keep vitest default excludes - #63

Open
dreyfus92 wants to merge 2 commits into
mainfrom
fix/vitest-default-excludes
Open

dreyfus92 wants to merge 2 commits into
mainfrom
fix/vitest-default-excludes

Conversation

@dreyfus92

Copy link
Copy Markdown
Member

the shared vitest config sets exclude: ['dist/**', 'node_modules/**'], which replaces vitest's defaults instead of extending them. node_modules/** only matches the root one, so in a pnpm workspace run from the root vitest follows the workspace symlinks into nested node_modules and runs the same tests again. now it spreads configDefaults.exclude and keeps dist/**.

added a test that runs bsh test against a workspace with a symlinked package and checks only the real test file gets collected, it fails on main without the fix.

@changeset-bot

changeset-bot Bot commented Sep 15, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 839721a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bomb.sh/tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Sep 15, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@bomb.sh/tools@63

commit: 839721a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant