Repository navigation
fix: stop completing a root command argument again after it has been given - #159
Open
MgmClientGuy0 wants to merge 1 commit into
Open
MgmClientGuy0 wants to merge 1 commit into
MgmClientGuy0 wants to merge 1 commit into
Conversation
…given
`handlePositionalCompletion` subtracts the command's name words from the
typed words to find the argument index. The root command's value is '',
and ''.split(' ') has length 1, so one argument too few was counted:
after `my-cli my-app <TAB>` the root's first argument was completed again.
🦋 Changeset detectedLatest commit: ab96586 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently, once a root command positional argument is typed, the same argument is suggested again afterwards instead of moving to the next argument. You can see it in the demo, which currently prints "my-app" again after the "my-app" argument was already given. This affects all positions, not just the first.
In contrast, for sub-commands, the argument is not repeated:
handlePositionalCompletioncurrently finds the argument index by subtracting the command name words from the typed words. For the root commandvalueis'', and''.split(' ')has length 1, which is incorrect.This does not conflict with #155 and they have the same type of fix for a different reason, see here.
Type of change
Checklist
pnpm test)pnpm format)AI-generated code disclosure