Repository navigation
fix: keep the shell directive set by an option or argument handler - #158
Open
MgmClientGuy0 wants to merge 1 commit into
Open
MgmClientGuy0 wants to merge 1 commit into
MgmClientGuy0 wants to merge 1 commit into
Conversation
`complete()` reset `directive` to `ShellCompDirectiveNoFileComp` after the handlers had run, so a handler could not choose file or directory completion. Reset it at the start of `parse()` instead: the default stays `:4`, and a handler can set e.g. `ShellCompDirectiveDefault` or `ShellCompDirectiveFilterDirs` for its completion request.
🦋 Changeset detectedLatest commit: 7f7fc32 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
complete()currently resets the shelldirectiveto the hardcodedShellCompDirectiveNoFileCompafter the option handlers had run. Any user that wants to support file or directory completions could not change this.#97 already proposed falling back to file completion automatically and was closed in favour of letting the user choose. This PR should allow a user to do that. This should be non-breaking. Any existing code still defaults to
ShellCompDirectiveNoFileComp.Type of change
Checklist
pnpm test)pnpm format)AI-generated code disclosure