Skip to content

chore: migration to @bomb.sh/tools #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mixto wants to merge 7 commits into
base: main
Choose a base branch
from
+2,065 −1,819
Open

chore: migration to @bomb.sh/tools #604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
70240c1
setup org tools
mixto Sep 13, 2026
6cc832e
remove unbuild
mixto Sep 13, 2026
7ebf515
cleanup dependencies & knip dlx
mixto Sep 13, 2026
19dc689
use defined tsconfig.json
mixto Sep 13, 2026
2392804
fix: typescript error TS4114
mixto Sep 13, 2026
2f71683
Merge branch 'bombshell-dev:main' into bsh
mixto Sep 13, 2026
168c1c5
root test command
mixto Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# macOS
.DS_Store

# Logs
Expand Down
6 changes: 0 additions & 6 deletions .vscode/extensions.json
View file
Open in desktop

This file was deleted.

36 changes: 0 additions & 36 deletions biome.json
View file
Open in desktop

This file was deleted.

17 changes: 0 additions & 17 deletions build.preset.ts
View file
Open in desktop

This file was deleted.

14 changes: 7 additions & 7 deletions examples/basic/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,8 @@
{
"name": "@example/basic",
"private": true,
"version": "0.0.0",
"type": "module",
"dependencies": {
"@clack/prompts": "workspace:*",
"arktype": "^2.2.0",
"picocolors": "^1.0.0",
"jiti": "^1.17.0"
},
"private": true,
"scripts": {
"start": "jiti ./index.ts",
"stream": "jiti ./stream.ts",
Expand All @@ -20,6 +14,12 @@
"spinner-timer": "jiti ./spinner-timer.ts",
"task-log": "jiti ./task-log.ts"
},
"dependencies": {
"@clack/prompts": "workspace:*",
"arktype": "^2.2.0",
"picocolors": "^1.0.0",
"jiti": "^1.17.0"
},
"devDependencies": {
"cross-env": "^7.0.3"
}
Expand Down
13 changes: 6 additions & 7 deletions examples/changesets/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,14 @@
{
"name": "@example/changesets",
"private": true,
"version": "0.0.0",
"type": "module",
"dependencies": {
"jiti": "^1.17.0",
"@clack/prompts": "workspace:*",
"picocolors": "^1.0.0"
},
"private": true,
"scripts": {
"start": "jiti ./index.ts"
},
"devDependencies": {}
"dependencies": {
"@clack/prompts": "workspace:*",
"jiti": "^1.17.0",
"picocolors": "^1.0.0"
}
}
3 changes: 0 additions & 3 deletions knip.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
{
"workspaces": {
".": {
"ignore": ["build.preset.ts"]
},
"examples/*": {
"entry": "*.ts!",
"project": "*.ts"
Expand Down
16 changes: 7 additions & 9 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,26 @@
{
"name": "@clack/root",
"private": true,
"type": "module",
"private": true,
"scripts": {
"stub": "pnpm -r run build --stub",
"build": "pnpm --filter \"@clack/*\" run build",
"start": "pnpm run dev",
"dev": "pnpm --filter @example/changesets run start",
"format": "biome check --write",
"lint": "biome lint --write --unsafe",
"format": "bsh format",

@dreyfus92 dreyfus92 Sep 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heads up that once this merges the format workflow runs bsh format on main and auto-commits the result. bsh format --check flags 67 files here, including src, tests, the workflow yaml and CONTRIBUTING.md. the ignorePatterns in tools' oxfmt config resolve relative to that config's own folder, so they don't cover our md/yml/json. could we run it in this pr so the reformat gets reviewed?

"lint": "bsh lint",
"types": "tsc --noEmit",
"deps": "pnpm exec knip --production",
"test": "pnpm --color -r run test",
"deps": "pnpm dlx knip --production",

@43081j 43081j Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bsh lint already runs knip afaiu. double check but we may be able to remove this script entirely

@mixto mixto Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a workflow that explicitly uses the deps script. It can be removed! Running bsh lint instead at the workflow won't pass due to oxc. A whole host of errors and warnings are being triggered.

@dreyfus92 dreyfus92 Sep 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree it can't be bsh lint yet, it exits 1 here with 59 errors, and its knip findings are warnings that never fail the run, without --production either. but pnpm dlx pulls knip outside the lockfile on every ci run, so the gate's version floats. could we keep knip as pinned devDep and leave the script as pnpm exec kinp --production?

"test": "bsh test",
"pretest": "pnpm run build"
},
"devDependencies": {
"@biomejs/biome": "^2.5.12",
"@bomb.sh/tools": "^0.6.1",
"@changesets/changelog-github": "^0.7.0",
"@changesets/cli": "^2.31.0",
"@types/node": "^20.19.39",
"jsr": "^0.13.4",
"knip": "^5.62.0",
"typescript": "^6.0.3",
"unbuild": "^3.6.0"
"typescript": "^6.0.3"
},
"packageManager": "pnpm@10.33.0",
"volta": {
Expand Down
7 changes: 0 additions & 7 deletions packages/core/build.config.ts
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,16 +50,16 @@
"node": ">= 20.12.0"
},
"scripts": {
"build": "unbuild",
"build": "bsh build",
"prepack": "pnpm build",
"test": "vitest run"
"test": "bsh test"
},
"dependencies": {
"fast-wrap-ansi": "^0.2.0",
"sisteransi": "^1.0.5"
},
"devDependencies": {
"arktype": "^2.2.0",
"vitest": "^3.2.4"
"vitest": "^5.0.0"
}
}
2 changes: 1 addition & 1 deletion packages/core/test/mock-readable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { Readable } from 'node:stream';
export class MockReadable extends Readable {
protected _buffer: unknown[] | null = [];

_read() {
override _read() {
if (this._buffer === null) {
this.push(null);
return;
Expand Down
2 changes: 1 addition & 1 deletion packages/core/test/mock-writable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { Writable } from 'node:stream';
export class MockWritable extends Writable {
public buffer: string[] = [];

_write(
override _write(
chunk: any,
_encoding: BufferEncoding,
callback: (error?: Error | null | undefined) => void
Expand Down
6 changes: 0 additions & 6 deletions packages/prompts/build.config.ts
View file
Open in desktop

This file was deleted.

8 changes: 4 additions & 4 deletions packages/prompts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@
"node": ">= 20.12.0"
},
"scripts": {
"build": "unbuild",
"build": "bsh build",

@dreyfus92 dreyfus92 Sep 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

building prompts writes 38 untracked .d.ts and .d.ts.map files into packages/core/src, and since pretest builds, every pnpm test leaves them behind. the dts step picks up packages/prompts/tsconfig.json as its root, and the root paths alias pulls core's sources in from outside it, so their declarations land next to them. dropping packages/prompts/tsconfig.json so it falls back to the root one builds with no stray files. could we try that here?

"prepack": "pnpm build",
"test": "vitest run"
"test": "bsh test"
},
"dependencies": {
"@clack/core": "workspace:*",
Expand All @@ -63,7 +63,7 @@
"devDependencies": {
"is-unicode-supported": "^1.3.0",
"memfs": "^4.17.2",
"vitest": "^3.2.4",
"vitest-ansi-serializer": "^0.1.2"
"vitest": "^5.0.0",
"vitest-ansi-serializer": "^0.3.1"
}
}
4 changes: 2 additions & 2 deletions packages/prompts/test/test-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export class MockWritable extends Writable {
public columns = 80;
public rows = 20;

_write(
override _write(
chunk: any,
_encoding: BufferEncoding,
callback: (error?: Error | null | undefined) => void
Expand All @@ -19,7 +19,7 @@ export class MockWritable extends Writable {
export class MockReadable extends Readable {
protected _buffer: unknown[] | null = [];

_read() {
override _read() {
if (this._buffer === null) {
this.push(null);
return;
Expand Down
10 changes: 0 additions & 10 deletions packages/prompts/vitest.config.ts
View file
Open in desktop

This file was deleted.

Loading
Loading