Skip to content

🎨 Palette: Add keyboard focus states to Toast, Modal, and HubTile components #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bobdivx merged 1 commit into from
Nov 2, 2026
Merged

🎨 Palette: Add keyboard focus states to Toast, Modal, and HubTile components #297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/web/src/components/ui/HubTile.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { enterUp, interactiveLift, motion, settleIn } from '../../lib/motion';
*/

const TILE_CLASS =
'group flex h-full min-h-[8.75rem] w-full min-w-0 cursor-pointer overflow-hidden flex-col items-center gap-2 rounded-2xl bg-[#1c1c1e] px-2.5 py-3 text-center ring-1 ring-transparent transition-[background-color,box-shadow,ring-color] duration-200 hover:bg-[#252528] hover:ring-white/15 hover:shadow-[0_12px_40px_rgb(0_0_0/0.35)] sm:gap-3 sm:px-3 sm:py-4';
'group flex h-full min-h-[8.75rem] w-full min-w-0 cursor-pointer overflow-hidden flex-col items-center gap-2 rounded-2xl bg-[#1c1c1e] px-2.5 py-3 text-center ring-1 ring-transparent transition-[background-color,box-shadow,ring-color] duration-200 hover:bg-[#252528] hover:ring-white/15 hover:shadow-[0_12px_40px_rgb(0_0_0/0.35)] focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-[var(--color-accent)] sm:gap-3 sm:px-3 sm:py-4';

const TILE_SQUARE = 'justify-center sm:aspect-square sm:min-h-[10.5rem]';
const TILE_AUTO = 'justify-start';
Expand Down Expand Up @@ -178,7 +178,7 @@ export function HubAddTile({
type="button"
onClick={onClick}
class={cn(
'group flex h-full min-h-[8.75rem] w-full cursor-pointer flex-col items-center gap-2 rounded-2xl border border-dashed border-white/15 bg-[#1c1c1e] px-2.5 py-3 transition-[background-color,border-color,box-shadow] duration-200 hover:border-white/30 hover:bg-[#252528] hover:shadow-[0_12px_40px_rgb(0_0_0/0.35)] sm:gap-3 sm:px-3 sm:py-4',
'group flex h-full min-h-[8.75rem] w-full cursor-pointer flex-col items-center gap-2 rounded-2xl border border-dashed border-white/15 bg-[#1c1c1e] px-2.5 py-3 transition-[background-color,border-color,box-shadow] duration-200 hover:border-white/30 hover:bg-[#252528] hover:shadow-[0_12px_40px_rgb(0_0_0/0.35)] focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-[var(--color-accent)] sm:gap-3 sm:px-3 sm:py-4',
layout === 'auto' ? 'justify-start' : 'justify-center sm:aspect-square sm:min-h-0',
)}
animate={motion((settle ? settleIn : enterUp)(Math.min(index * 0.045, 0.32)), interactiveLift())}
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/components/ui/Modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ export function Modal({
</div>
<button
type="button"
class="-mr-2 -mt-1.5 flex h-11 w-11 shrink-0 items-center justify-center rounded-lg text-base text-[var(--color-ink-muted)] hover:bg-white/5 hover:text-[var(--color-ink)] lg:-mr-1 lg:-mt-0.5 lg:h-8 lg:w-8 lg:text-sm"
class="-mr-2 -mt-1.5 flex h-11 w-11 shrink-0 items-center justify-center rounded-lg text-base text-[var(--color-ink-muted)] transition hover:bg-white/5 hover:text-[var(--color-ink)] focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-[var(--color-accent)] lg:-mr-1 lg:-mt-0.5 lg:h-8 lg:w-8 lg:text-sm"
onClick={onClose}
aria-label="Fermer"
>
Expand Down
4 changes: 2 additions & 2 deletions apps/web/src/components/ui/Toast.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export function ToastProvider({ children }: { children: ComponentChildren }) {
{t.action && (
<button
type="button"
class="mt-1.5 inline-flex min-h-[44px] items-center rounded-lg px-2 text-sm font-semibold text-[var(--color-accent)] hover:bg-white/5 sm:min-h-[32px]"
class="mt-1.5 inline-flex min-h-[44px] items-center rounded-lg px-2 text-sm font-semibold text-[var(--color-accent)] transition hover:bg-white/5 focus-visible:outline-2 focus-visible:outline-[var(--color-accent)] sm:min-h-[32px]"
onClick={() => {
t.action?.onClick();
dismiss(t.id);
Expand All @@ -81,7 +81,7 @@ export function ToastProvider({ children }: { children: ComponentChildren }) {
</div>
<button
type="button"
class="text-[var(--color-ink-faint)] hover:text-[var(--color-ink)]"
class="rounded text-[var(--color-ink-faint)] transition hover:text-[var(--color-ink)] focus-visible:outline-2 focus-visible:outline-[var(--color-accent)]"
aria-label="Fermer"
onClick={() => dismiss(t.id)}
>
Expand Down
Loading