feat(engine): include the value type in "not a constructor" errors - #5488
Open
ChrisJr404 wants to merge 1 commit into
Open
feat(engine): include the value type in "not a constructor" errors#5488ChrisJr404 wants to merge 1 commit into
ChrisJr404 wants to merge 1 commit into
Conversation
Test262 conformance changes
Tested main commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request closes #1760.
Summary
Right now every "not a constructor"
TypeErroruses the same bare message, so when you hit one it doesn't tell you anything about what went wrong. This adds the type of the value to the message and makes the wording consistent across the places that throw it.So
new 5()now throws "number is not a constructor",new undefined()throws "undefined is not a constructor", andnew (() => {})()throws "function is not a constructor". This matches the style already used for the builtin messages like "Symbol is not a constructor".Changes
NewandNewSpreadopcodes prepend the operand'stype_ofwhen it isn't an object.non_existent_constructreports "function" or "object" depending on whether the target is callable, which covers callable objects without a[[Construct]]slot (arrow functions, methods, etc.).I left the variable-name idea out for now since the name isn't reliably available at these throw sites, but the type is, and it's the part that's always useful.