Initial architecture documentation for bytecompiler module #4757
Initial architecture documentation for bytecompiler module #4757JkrishnaD wants to merge 1 commit intoboa-dev:mainfrom
Conversation
|
@jedel1043 as we discussed in issue #1608. I've made a pr with initial documentation for the Let me know that if there any changes needed here. so that we can move forward from there |
Test262 conformance changes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4757 +/- ##
==========================================
+ Coverage 47.24% 57.05% +9.81%
==========================================
Files 476 552 +76
Lines 46892 60568 +13676
==========================================
+ Hits 22154 34559 +12405
- Misses 24738 26009 +1271 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jedel1043
left a comment
There was a problem hiding this comment.
Docs are looking great! It might just need a bit more detail
There was a problem hiding this comment.
Looks good so far, but you only mentioned what the bytecompiler does, not how it does it.
- Is it register based, stack based or other type?
- Does it use a string interner?
- How does it resolve bindings and environments?
- What about async? Does it lower async/generators to state machines or to some other execution model?
- etc.
There was a problem hiding this comment.
yeah sure i'll add about all these
b41fd77 to
93bbd90
Compare
This Pull Request fixes/closes #1608 .
This PR adds initial high-level module documentation for the bytecompiler,
which mainly focusing on:
This is intended as a starting point to discuss structure and scope for further documentation improvements.