feat(intl): implement Intl.DateTimeFormat.prototype.resolvedOptions()#4753
Open
Lokesh0224 wants to merge 4 commits intoboa-dev:mainfrom
Open
feat(intl): implement Intl.DateTimeFormat.prototype.resolvedOptions()#4753Lokesh0224 wants to merge 4 commits intoboa-dev:mainfrom
Lokesh0224 wants to merge 4 commits intoboa-dev:mainfrom
Conversation
Test262 conformance changes
Fixed tests (28):Broken tests (8): |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4753 +/- ##
==========================================
+ Coverage 47.24% 57.18% +9.94%
==========================================
Files 476 552 +76
Lines 46892 60572 +13680
==========================================
+ Hits 22154 34638 +12484
- Misses 24738 25934 +1196 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3a63f16 to
c7059c2
Compare
Contributor
Author
|
@jedel1043, can you kindly go through the chat regarding // TODO: determine the correct way to verify the calendar algorithm data. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the missing
resolvedOptions()onDateTimeFormat— it was throwingTypeError: not a callable function.This PR implements the method following the
ECMA-402 11.3.2. Added the missing internal slots (
numbering_system,hour_cycle,date_style,time_style) to the struct and populated them during construction.LIMITATION
unicode-org/icu4x#5868
ICU4X does not yet expose the resolved
calendar,numberingSystem, andhourCyclefrom a constructed
DateTimeFormatter, so ECMA-402 defaults are used as fallbacks.Explicitly passed options are always reflected correctly.
Test262
resolvedOptions: 1/21 → 6/21before resolvedOptoins():

after resolvedOptoins():
