Replace ByteCodeEmitter::emit_xxx() with Opcode::emit() associated functions#4752
Open
hansl wants to merge 4 commits intoboa-dev:mainfrom
Open
Replace ByteCodeEmitter::emit_xxx() with Opcode::emit() associated functions#4752hansl wants to merge 4 commits intoboa-dev:mainfrom
hansl wants to merge 4 commits intoboa-dev:mainfrom
Conversation
…nctions Move opcode emission from methods on ByteCodeEmitter (e.g. `self.bytecode.emit_push_undefined(dst)`) to associated functions on each opcode struct (e.g. `PushUndefined::emit(self, dst)`). This makes it easier to search for all emission sites of a given opcode and aligns the API with the opcode type system. The old `emit_xxx` methods generated by the `generate_opcodes!` macro are removed and replaced by a single `Variant::emit(compiler, ...)` pattern generated in the same macro. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move opcode emission from methods on ByteCodeEmitter (e.g.
self.bytecode.emit_push_undefined(dst)) to associated functions on each opcode struct (e.g.PushUndefined::emit(self, dst)). This makes it easier to search for all emission sites of a given opcode and aligns the API with the opcode type system.The old
emit_xxxmethods generated by thegenerate_opcodes!macro are removed and replaced by a singleVariant::emit(compiler, ...)pattern generated in the same macro.