feat(builtins): implement JsWeakSet safe wrapper#4739
feat(builtins): implement JsWeakSet safe wrapper#4739jedel1043 merged 5 commits intoboa-dev:mainfrom
Conversation
Test262 conformance changes
Fixed tests (1): |
hey i made some changes in #4724 as you suggested to me is it loooks fine |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4739 +/- ##
==========================================
+ Coverage 47.24% 57.18% +9.93%
==========================================
Files 476 552 +76
Lines 46892 60494 +13602
==========================================
+ Hits 22154 34591 +12437
- Misses 24738 25903 +1165 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks fine, just needs a |
Yup ,while solving the conflicts in Jsweakmap and and weakset ,Ithe web one we uses I think it didn't do the cargo fmt , let me do Manually |
|
@jedel1043 did the jsgeneratorfunction and the Asyncgenerator isn't checked on original pr #2098 is it currently outof scope(if they are in scope or not yet solved I think it can be fixed with the same process if i am not mistaken ,if that's the case I loved to raise pr for it), also thanks for quick guidence in this pr. I learned alot |
Implements `JsWeakSet` as a safe Rust wrapper around the ECMAScript `WeakSet` builtin, as part of boa-dev#2098. ## Changes - `core/engine/src/object/builtins/jsweakset.rs` — new `JsWeakSet` wrapper with all methods - `core/engine/src/object/builtins/mod.rs` — registered and re-exported `JsWeakSet` - `examples/src/bin/jsweakset.rs` — usage example ## Methods implemented - `new` — creates an empty WeakSet - `add` — adds an object to the set - `has` — checks if an object exists - `delete` — removes an object - `from_object` — converts `JsObject` to `JsWeakSet` Follows the same pattern as `JsWeakMap` (boa-dev#4738) and `JsSet`. Closes part of boa-dev#2098
Implements `JsWeakSet` as a safe Rust wrapper around the ECMAScript `WeakSet` builtin, as part of boa-dev#2098. ## Changes - `core/engine/src/object/builtins/jsweakset.rs` — new `JsWeakSet` wrapper with all methods - `core/engine/src/object/builtins/mod.rs` — registered and re-exported `JsWeakSet` - `examples/src/bin/jsweakset.rs` — usage example ## Methods implemented - `new` — creates an empty WeakSet - `add` — adds an object to the set - `has` — checks if an object exists - `delete` — removes an object - `from_object` — converts `JsObject` to `JsWeakSet` Follows the same pattern as `JsWeakMap` (boa-dev#4738) and `JsSet`. Closes part of boa-dev#2098
Implements
JsWeakSetas a safe Rust wrapper around the ECMAScriptWeakSetbuiltin, as part of #2098.Changes
core/engine/src/object/builtins/jsweakset.rs— newJsWeakSetwrapper with all methodscore/engine/src/object/builtins/mod.rs— registered and re-exportedJsWeakSetexamples/src/bin/jsweakset.rs— usage exampleMethods implemented
new— creates an empty WeakSetadd— adds an object to the sethas— checks if an object existsdelete— removes an objectfrom_object— convertsJsObjecttoJsWeakSetFollows the same pattern as
JsWeakMap(#4738) andJsSet.Closes part of #2098