fix: implement TryIntoJs and TryFromJs for common Rust wrapper types#4727
Open
jakharmonika364 wants to merge 1 commit intoboa-dev:mainfrom
Open
fix: implement TryIntoJs and TryFromJs for common Rust wrapper types#4727jakharmonika364 wants to merge 1 commit intoboa-dev:mainfrom
jakharmonika364 wants to merge 1 commit intoboa-dev:mainfrom
Conversation
e1b538a to
becb9be
Compare
Test262 conformance changes
|
Contributor
|
Just want to clarify, this PR does not change the TryIntoJs macro, what am I missing? |
Author
|
I noticed after pushing that the prototype fix in the macro was already there in main. The main point of this PR now is implementing TryIntoJs and TryFromJs from wrapper types. I had to refactor how native classes handle conversion to resolve a trait conflict that was previously blocking those wrapper implementations. I'll update the PR description to reflect the actual changes. |
becb9be to
2fd34c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4360
This PR implements TryIntoJs and TryFromJs for common Rust wrapper types and refactors class conversions to resolve trait conflicts.
Key Changes: