[RELEASE] version 1.1.1 #12
Conversation
bnbong
added
bug
There was a problem hiding this comment.
Pull Request Overview
This PR is an official release version 1.1.1 focused on fixing template inspection workflow compatibility with the UV package manager and improving template testing infrastructure.
- Fixed template inspection to use UV package manager for better compatibility
- Updated all template pyproject.toml files to support modern Python packaging
- Enhanced GitHub Actions workflow for template inspection with UV support
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_backends/test_inspector.py | Updated test mocks to use new dependency installation function and added requirements.txt creation for test compatibility |
| Multiple pyproject.toml-tpl files | Added complete pyproject.toml configuration files for all FastAPI templates with modern Python packaging standards |
| Multiple config.py-tpl files | Updated type annotations from Python 3.10+ union syntax to backward-compatible Union syntax |
| src/fastapi_fastkit/core/settings.py | Added pyproject.toml to template path detection configuration |
| src/fastapi_fastkit/backend/package_managers/uv_manager.py | Enhanced UV manager to install dev dependencies and added better logging |
| src/fastapi_fastkit/backend/main.py | Added pyproject.toml processing functionality and metadata injection |
| src/fastapi_fastkit/backend/inspector.py | Enhanced template inspector with package manager detection and dummy metadata injection |
| src/fastapi_fastkit/init.py | Bumped version to 1.1.1 |
| CHANGELOG.md | Added changelog entry for version 1.1.1 |
| .github/workflows/template-inspection.yml | Added UV installation and enhanced workflow reporting |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
| # The module defines custom Backend Application Exception class, overrides basic Exception. | ||
| # -------------------------------------------------------------------------- | ||
| from datetime import UTC, datetime | ||
| from datetime import datetime, timezone |
There was a problem hiding this comment.
[nitpick] While datetime.timezone.utc is the correct modern approach, consider importing it as UTC for consistency with the existing codebase pattern: from datetime import datetime, timezone as UTC. Then use UTC.utc instead of timezone.utc to maintain naming consistency.
| from datetime import datetime, timezone | |
| from datetime import datetime, timezone as UTC |
src/fastapi_fastkit/fastapi_project_template/fastapi-async-crud/pyproject.toml-tpl
Outdated
Show resolved
Hide resolved
| debug_log( | ||
| f"Service info is not a dictionary: {service}", | ||
| "warning", | ||
| ) |
There was a problem hiding this comment.
The service type validation logic is duplicated in two locations (_wait_for_services_healthy and _verify_services_running). This could lead to maintenance issues. Consider extracting this validation into a helper method like _validate_service_info(service) to avoid code duplication.
| ) | |
| if not self._validate_service_info(service): |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…d/pyproject.toml-tpl Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Requesting Merging
Description
official release version 1.1.1
Type of Change
Test Environment
local, MacOS Apple Silicon
Major Changes
uvpackage managerScreenshots (optional)
Etc
close #11