Repository navigation
Remove Python 3.10 - #97
Merged
Merged
Conversation
Contributor
|
The correct way to address the pixi issue is to specify the environment in each action the same way it is done here: https://github.com/Igort4/bluesky-queueserver/blob/dee17fb8ee2f77c4e169f88e332f261a172176d6/.github/workflows/testing.yml#L68-L70 |
Contributor
Author
|
@dmgav I use it locally on my machine |
Contributor
|
Probably formatting broke the unit tests. It also used to pass pre-commit tests, there should be no style issues. |
Contributor
Author
Contributor
Author
|
Style issues in pre-commit are from upgrading to Python 3.11 as the minimum. Ruff detects new rules to apply in this case (e.g. since |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Drops Python 3.10 since it is now end-of-life: https://devguide.python.org/versions/
Also, caps
pixi.toml's Python to 3.14 since it was defaulting to 3.15 and many packages do not support it yet. Pixi would fail to install.Motivation and Context
Standard min Python version bump.
Summary of Changes for Release Notes
Included in release notes.
Fixed
Added
Changed
Removed
How Has This Been Tested?
There already were no tests for python 3.10