Skip to content

Normalize enable argument in control functions #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DeepPG wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −3
Open

Normalize enable argument in control functions #742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bac5bf
Normalize enable argument in control functions
DeepPG Aug 8, 2026
d261544
Already implemented as HCI_EVENT_META_GAP
DeepPG Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/btstack_defines.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2131,7 +2131,6 @@ typedef SSIZE_T ssize_t;

// Potential other meta groups
// #define HCI_EVENT_BNEP_META 0xxx
// #define HCI_EVENT_GAP_META 0xxx
// #define HCI_EVENT_GATT_META 0xxx
// #define HCI_EVENT_PAN_META 0xxx
// #define HCI_EVENT_SDP_META 0xxx
Expand Down
4 changes: 2 additions & 2 deletions src/hci.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6405,7 +6405,7 @@ static void hci_update_scan_enable(void){
}

void gap_discoverable_control(uint8_t enable){
if (enable) enable = 1; // normalize argument
enable = !!enable // normalize argument

if (hci_stack->discoverable == enable){
hci_emit_scan_mode_changed(hci_stack->discoverable, hci_stack->connectable);
Expand All @@ -6417,7 +6417,7 @@ void gap_discoverable_control(uint8_t enable){
}

void gap_connectable_control(uint8_t enable){
if (enable) enable = 1; // normalize argument
enable = !!enable // normalize argument

// don't emit event
if (hci_stack->connectable == enable) return;
Expand Down