Skip to content

Selectively skip received methods after sending channel.close - #112

Merged
michalovits merged 3 commits into
bloomberg:mainfrom
michalovits:skip-after-channel-close
Nov 10, 2026
Merged

michalovits merged 3 commits into
bloomberg:mainfrom
michalovits:skip-after-channel-close

Conversation

@michalovits

Copy link
Copy Markdown
Contributor

The AMQP 0-9-1 spec for channel.close says:

After sending this method, any received methods except Close and Close-OK MUST be discarded.

Do exactly that when we're in the CHANNEL_CLOSE_SENT state. For example, we could produce a double close when basic.cancel came in just after we'd sent channel.close.

@michalovits
michalovits requested a review from a team November 9, 2026 17:55
@michalovits michalovits changed the title Selectively skip received frames after sending channel.close Selectively skip received methods after sending channel.close Nov 9, 2026
@michalovits
michalovits enabled auto-merge (squash) November 10, 2026 17:46
@michalovits
michalovits merged commit 0fd78ff into bloomberg:main Nov 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants