fix: disallow negative chunk_size parameter in comdb2_files#5992
Open
SChakravorti21 wants to merge 1 commit into
Open
fix: disallow negative chunk_size parameter in comdb2_files#5992SChakravorti21 wants to merge 1 commit into
chunk_size parameter in comdb2_files#5992SChakravorti21 wants to merge 1 commit into
Conversation
Validate that `chunk_size` is positive before passing it to the file reading pipeline. A negative value (e.g. `-1`) would propagate through `set_chunk_size`/`dbfile_set_chunk_size` and trigger an assertion in `ar_wrap.c:read_write_file()`, aborting the server process. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Shoumyo Chakravorti <schakravorti@bloomberg.net>
roborivers
suggested changes
May 30, 2026
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: 4/675 tests failed ⚠.
The first 10 failing tests are:
sp_snapshot_generated
consumer_non_atomic_default_consumer_generated **quarantined**
remotecreate_twopc_generated
remotecreate
truncatesc_offline_generated [timeout] **quarantined**
reco-ddlk-sql [timeout] **quarantined**
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chunk_sizeis positive infiles_util_filter()before passing it to the file reading pipeline-1) would propagate throughset_chunk_size/dbfile_set_chunk_sizeand trigger the assertionf->chunk_size > 0inar_wrap.c:read_write_file(), aborting the server processtest_comdb2_files_negative_chunk_sizethat verifies the server stays alive after achunk_size = -1queryTest plan
make comdb2_filespasses locally (all existing tests + new negative chunk_size test)🤖 Generated with Claude Code