Skip to content

fix some issues in the retired remtran protocol#5973

Open
dorinhogea wants to merge 3 commits into
bloomberg:mainfrom
dorinhogea:fixremtran
Open

fix some issues in the retired remtran protocol#5973
dorinhogea wants to merge 3 commits into
bloomberg:mainfrom
dorinhogea:fixremtran

Conversation

@dorinhogea
Copy link
Copy Markdown
Contributor

@dorinhogea dorinhogea commented May 27, 2026

re:184332936
re:184332944
re:184399406

re:184332936

Signed-off-by: dhogea <dhogea@bloomberg.net>
Signed-off-by: dhogea <dhogea@bloomberg.net>
re: 184399406

Signed-off-by: dhogea <dhogea@bloomberg.net>
Copy link
Copy Markdown

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
sp_snapshot_generated
consumer_non_atomic_default_consumer_generated **quarantined**
longreq_stats
skipscan **quarantined**
truncatesc_offline_generated [timeout] **quarantined**

Copy link
Copy Markdown

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_truncate_multiddl_generated [db unavailable at finish] **quarantined**
sc_resume_logicalsc_generated **quarantined**
consumer_non_atomic_default_consumer_generated **quarantined**
unifiedcancel **quarantined**
sc_redo [timeout]
reco-ddlk-sql [timeout] **quarantined**

Comment thread plugins/remsql/fdb_comm.c
return -1;
rc = cdb2buf_fread(msg->de.tblname, 1, tmp, sb);
if (rc != tmp)
return -1;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaks de.tblname allocated above on error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants