Document validateSource's rejection cases in index_data.painless - #1357
Open
nikhilkumarjadhav-toast wants to merge 1 commit into
Open
Document validateSource's rejection cases in index_data.painless#1357nikhilkumarjadhav-toast wants to merge 1 commit into
nikhilkumarjadhav-toast wants to merge 1 commit into
Conversation
Adds a doc comment to validateSource -- the one main function in the script without one -- describing its two rejection cases. Comment-only change, no behavior change. Schema artifacts regenerated and INDEX_DATA_UPDATE_SCRIPT_ID rolled accordingly.
nikhilkumarjadhav-toast
requested review from
BrianSigafoos-SQ,
bsorbo,
ellisandrews-toast,
jwils,
jwondrusch,
marcdaniels-toast,
myronmarston and
rossroberts-toast
as code owners
August 19, 2026 00:24
myronmarston
approved these changes
Aug 19, 2026
myronmarston
enabled auto-merge (squash)
August 19, 2026 07:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validateSource— the one main function inindex_data.painlesswithout one — describing its two rejection cases (source-document identity change, stale/duplicate event version).INDEX_DATA_UPDATE_SCRIPT_IDrolled accordingly (same mechanics as index_data.painless script cleanup #1308).Test plan
rake schema_artifacts:dumprun twice — idempotent after the first dumpelasticgraph-schema_definition: static scripts, scripting, and update-targets specs — 134 examples, 0 failureselasticgraph-indexer: update + datastore-indexing-router specs — 42 examples, 0 failures