fix(desktop-tooltips): migrate tooltips from primary to secondary - #6290
Closed
tellaho wants to merge 2 commits into
Closed
fix(desktop-tooltips): migrate tooltips from primary to secondary#6290tellaho wants to merge 2 commits into
tellaho wants to merge 2 commits into
Conversation
Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
Contributor
Author
|
Consolidated into #6252 at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category: fix
User Impact: Tooltips now use the secondary color surface instead of the primary accent while remaining readable across light and dark themes.
Problem: The shared tooltip and several rich-tooltip descendants used primary surface and foreground tokens. Migrating only the shared background would leave nested descriptions, metadata, and chips coupled to the old primary surface and create contrast regressions.
Solution: Migrate the shared tooltip from the primary color pair to the secondary pair, migrate every confirmed rich descendant to matching secondary-foreground tokens, and remove the huddle tooltip’s misleading primary-token aliases while preserving its dedicated palette. Add light- and dark-theme browser coverage for both a simple tooltip and the rich add-channel team tooltip, plus a source contract test for the huddle token path.
File changes
desktop/src/shared/ui/tooltip.tsx
Changes the shared tooltip background and foreground from the primary pair to the semantic secondary pair.
desktop/src/features/agents/ui/RestartDiffBadge.tsx
Updates restart-diff values, overflow text, supporting copy, and documentation to match the secondary tooltip surface.
desktop/src/features/channels/ui/AddChannelBotTeamsSection.tsx
Updates team descriptions, persona chips, avatars, and names so the rich team tooltip retains contrast on the secondary surface.
desktop/src/features/projects/ui/ProjectAuthorIdentity.tsx
Updates the secondary author-role label to use the tooltip's matching semantic foreground.
desktop/src/features/projects/ui/ProjectCards.tsx
Aligns repository-unavailable tooltip descriptions with the secondary tooltip foreground.
desktop/src/shared/styles/globals/utilities.css
Makes huddle tooltips consume their dedicated surface and foreground tokens directly, preserving their custom palette without primary semantic aliases.
desktop/src/shared/styles/globals/tooltipSemantics.test.mjs
Pins direct huddle-token consumption and rejects primary or secondary alias indirection in the huddle tooltip rule.
desktop/tests/e2e/tooltip-semantics.spec.ts
Verifies computed tooltip surface colors and every migrated rich descendant token in Buzz light and Catppuccin Mocha dark themes, including team persona chips and avatars.
desktop/playwright.config.ts
Registers the tooltip semantics coverage in the desktop smoke suite.
Reproduction Steps
cd desktop && pnpm build:e2e.pnpm exec playwright test tests/e2e/tooltip-semantics.spec.ts --project=smoke.Screenshots/Demos