Skip to content

fix(desktop-tooltips): migrate tooltips from primary to secondary - #6290

Closed
tellaho wants to merge 2 commits into
mainfrom
tho/buzz-tooltip-semantics
Closed

fix(desktop-tooltips): migrate tooltips from primary to secondary#6290
tellaho wants to merge 2 commits into
mainfrom
tho/buzz-tooltip-semantics

Conversation

@tellaho

@tellaho tellaho commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Category: fix

User Impact: Tooltips now use the secondary color surface instead of the primary accent while remaining readable across light and dark themes.

Problem: The shared tooltip and several rich-tooltip descendants used primary surface and foreground tokens. Migrating only the shared background would leave nested descriptions, metadata, and chips coupled to the old primary surface and create contrast regressions.

Solution: Migrate the shared tooltip from the primary color pair to the secondary pair, migrate every confirmed rich descendant to matching secondary-foreground tokens, and remove the huddle tooltip’s misleading primary-token aliases while preserving its dedicated palette. Add light- and dark-theme browser coverage for both a simple tooltip and the rich add-channel team tooltip, plus a source contract test for the huddle token path.

File changes

desktop/src/shared/ui/tooltip.tsx
Changes the shared tooltip background and foreground from the primary pair to the semantic secondary pair.

desktop/src/features/agents/ui/RestartDiffBadge.tsx
Updates restart-diff values, overflow text, supporting copy, and documentation to match the secondary tooltip surface.

desktop/src/features/channels/ui/AddChannelBotTeamsSection.tsx
Updates team descriptions, persona chips, avatars, and names so the rich team tooltip retains contrast on the secondary surface.

desktop/src/features/projects/ui/ProjectAuthorIdentity.tsx
Updates the secondary author-role label to use the tooltip's matching semantic foreground.

desktop/src/features/projects/ui/ProjectCards.tsx
Aligns repository-unavailable tooltip descriptions with the secondary tooltip foreground.

desktop/src/shared/styles/globals/utilities.css
Makes huddle tooltips consume their dedicated surface and foreground tokens directly, preserving their custom palette without primary semantic aliases.

desktop/src/shared/styles/globals/tooltipSemantics.test.mjs
Pins direct huddle-token consumption and rejects primary or secondary alias indirection in the huddle tooltip rule.

desktop/tests/e2e/tooltip-semantics.spec.ts
Verifies computed tooltip surface colors and every migrated rich descendant token in Buzz light and Catppuccin Mocha dark themes, including team persona chips and avatars.

desktop/playwright.config.ts
Registers the tooltip semantics coverage in the desktop smoke suite.

Reproduction Steps

  1. Run cd desktop && pnpm build:e2e.
  2. Run pnpm exec playwright test tests/e2e/tooltip-semantics.spec.ts --project=smoke.
  3. In the app, hover the channel-members control and confirm the simple tooltip uses the neutral secondary surface.
  4. Open Add agents, hover a team, and confirm its description and persona chips remain readable.
  5. Repeat in the Buzz light and Catppuccin Mocha dark themes.

Screenshots/Demos

Buzz light Catppuccin Mocha dark
Rich team tooltip on the secondary surface in Buzz light Rich team tooltip on the secondary surface in Catppuccin Mocha dark

Co-authored-by: Taylor Ho <taylorkmho@gmail.com>
Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
@tellaho tellaho changed the title fix(desktop-tooltips): preserve contrast on secondary surfaces fix(desktop-tooltips): keep secondary surfaces readable Aug 19, 2026
@tellaho tellaho changed the title fix(desktop-tooltips): keep secondary surfaces readable fix(desktop-tooltips): migrate primary surfaces to secondary Aug 19, 2026
@tellaho tellaho changed the title fix(desktop-tooltips): migrate primary surfaces to secondary fix(desktop-tooltips): migrate tooltips from primary to secondary Aug 19, 2026
Co-authored-by: Taylor Ho <taylorkmho@gmail.com>
Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
@tellaho

tellaho commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

Consolidated into #6252 at 4f9d18e84acb2f014d73bf71e73f3e16d1bc8c81, preserving the secondary-tooltip migration, rich descendant token fixes, huddle contract coverage, and light/dark smoke coverage. Closing this superseded draft so review and CI have one source of truth.

@tellaho tellaho closed this Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant