Surface waits and prioritize Workstream Board cards - #6277
Draft
loganj wants to merge 5 commits into
Draft
Conversation
Signed-off-by: loganj <loganj@squareup.com>
Signed-off-by: loganj <loganj@squareup.com>
Signed-off-by: loganj <loganj@squareup.com>
Signed-off-by: loganj <loganj@squareup.com> Co-authored-by: Amp <amp@ampcode.com> Signed-off-by: loganj <loganj@squareup.com>
Signed-off-by: loganj <loganj@squareup.com> Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖
Summary
Workstream coordinators need to see what each card is waiting on and which work deserves attention first without opening every linked pull request. This final slice adds manual and review-derived waits, deterministic owner-first ordering, and compact card polish to the experiment-gated Workstream Board.
This is PR 4/4 in the Workstream Board stack, based on the presence-retry regression prerequisite. The board remains off by default under Settings → Experiments. This PR is draft, and auto-merge is off.
What changes
Scope boundary: external canvas revisions refresh after ordinary route remount/refetch, NOT via live external subscription or in-place refresh.
Related issue
None found. This is an experiment-gated product slice.
Testing
a39a72b918d5f290a01bf87e88a8cf604d5c851f: Workstream Board 52/52, presence reconciler 12/12, Desktop 5,090/5,090, typecheck and check passed.6e918ee1b806febe20e44cff7ce8dc05204e5b59: Desktop 5,011/5,011, focused tests 8/8, keyboard/accessibility 16/16, typecheck, check, production build, E2E build, and diff check passed.The validated implementation was rebased from
6e918ee1b806febe20e44cff7ce8dc05204e5b59toa39a72b918d5f290a01bf87e88a8cf604d5c851f. The B4 patch is byte-identical across that SHA migration; the new head was separately integration-validated after the stack rebase.Demo
▶ Watch the full uninterrupted 369.920-second relay-backed demo — SHA-256
e6406b4e6b9c1db129d899035667bc87609dd0da032c8b9e3abd6b65312148df.Additional full-board frames: manual publication before remount, manual removal before remount, sustained round one, and healthy terminal UI.
The capture proves owner-first/lookalike-safe ordering, manual override/removal, approval clearing, live card add/remove, and six sustained rounds over 334.424 seconds with bounded memory. All 32/32 mechanical gates and 9/9 complete relay-pipeline readiness gates passed.
Evidence archives:
2d62de4ed70256604eb79dea385c7ce963074f0a763750234bbcab38b91afdda; 696-entry manifest SHA-2564b9308947d24bbbc2d38d28fab9740bfd9263cd8e11d64affdc1f0a106f6b946.87ac6ac4db0bc95b03bc0803175ea981417f2dac934691d692177280926fcec9; 13-entry manifest SHA-256a316dcbaa13ec6d5edb7c34a5b347c1e366f36bc446dba16fc343e0dfc57beda.The source capture preserved one terminal validator failure caused by treating an explicit no-event rate-limit closure as an event-order violation. The separate correction leaves the source immutable and classifies its 65 relevant requests as 32 ordered event-bearing, 32 successful-empty, and one terminal-closed request, with zero actual ordering violations; its self-tests passed 35/35.
Stack
workstream-board/03a-presence-timer-retryworkstream-board/04-waits-sort-polishata39a72b918d5f290a01bf87e88a8cf604d5c851fDraft only; no auto-merge.