test(desktop): let relay state poll retry - #6254
Draft
santho090 wants to merge 1 commit into
Draft
Conversation
Signed-off-by: svaithiyanathan <svaithiyanathan@digitalocean.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expect.pollretry while the E2E relay-state hook is still being installedconnectedThe old callback threw when the hook was absent, which stopped the poll instead of letting it retry. This uses the same optional call pattern as the other relay-state polls in the file.
This PR addresses the order-dependent poll in #6242. The separate fixed-port environment note remains out of scope.
Related issue
Fixes #6242.
Testing
Relay state seam is not installed.pnpm -C desktop exec playwright test tests/e2e/relay-reconnect.spec.ts --project=smoke --workers=1: 14 passedpnpm -C desktop exec biome check tests/e2e/relay-reconnect.spec.tspnpm -C desktop typecheckjust ci