Fix presence retry timers after failed opens - #6253
Draft
loganj wants to merge 1 commit into
Draft
Conversation
loganj
force-pushed
the
workstream-board/03-pr-status
branch
from
August 19, 2026 00:48
f2aa42e to
2187add
Compare
loganj
force-pushed
the
workstream-board/03a-presence-timer-retry
branch
from
August 19, 2026 00:53
acd92ec to
c2a61b5
Compare
loganj
force-pushed
the
workstream-board/03-pr-status
branch
from
August 19, 2026 13:04
2187add to
e17b46d
Compare
loganj
force-pushed
the
workstream-board/03a-presence-timer-retry
branch
from
August 19, 2026 13:04
c2a61b5 to
307496e
Compare
Signed-off-by: loganj <loganj@squareup.com>
loganj
force-pushed
the
workstream-board/03-pr-status
branch
from
August 20, 2026 00:02
e17b46d to
05eb451
Compare
loganj
force-pushed
the
workstream-board/03a-presence-timer-retry
branch
from
August 20, 2026 00:02
307496e to
776d1f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖
Summary
The production presence-retry defect is already fixed on
mainby #6213. After rebasing onto that fix, this PR contains regression coverage only; it does not change production behavior.The retained test protects the stronger recovery lifecycle that exposed the defect: a failed subscription open schedules one bounded retry, a later attempt succeeds, a subsequent replacement can fail open, and disposal cancels the pending retry.
Related issue
Production fix: #6213
Testing
2892e4aa74fe6f1761550108fdda10e5164c0185, which includes the current regression prerequisite head307496e2e961e5193afebf28bc910cf6b3c8f9bd: presence reconciler 12/12, Workstream Board 52/52, Desktop 5,143/5,143, typecheck passed, and check completed with zero errors.Stack
This is the regression-only prerequisite between Workstream Board PR 3/4 and the final waits/sorting/polish PR. Draft only; auto-merge is off.
Discussion: Workstream Board thread