Repository navigation
Conversation
storage_partition_dedup_policy_paging_and_shrinking stamped each fixture event with the wall clock but pruned relative to the first event's time. prune(now + 86401) with a 1-day window removes only rows created at most 1 s after `now`. When the 205 ingests took over a second, as on a loaded runner, later rows survived and the "expired observer rows are gone" assertion at tests.rs:185 failed. All fixtures in the test now share the first event's timestamp, so the expiry boundary is exact regardless of runner speed. Production expiry code is unchanged. A 2.1 s delay inside the ingest loop reproduces the CI assertion on the old test and passes with this change. Signed-off-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖
Summary
storage_partition_dedup_policy_paging_and_shrinking) failed intermittently in CI when a runner was slow. It did not show a product bug.Details
prune(now + 86401)removes only rows stamped no more than 1 second afternow. If the test's 205 inserts took more than about a second, the later rows survived. Then the assertion "expired observer rows are gone" (tests.rs:185) failed. This happened in CI run 37623102186, attempt 1, where the archive tests took about 2 s. It passed on rerun.