Repository navigation
fix(staged): list overflowed footer buttons first in the timeline "…" menu - #973
Merged
Merged
Conversation
… menu Overflowed New note / New commit / New code review items now lead the menu in their footer order, so it reads as a continuation of the button row, with the manual "Write note" action below a separator. This also puts "New code review" above "Write note" as requested. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Matt Toohey <contact@matttoohey.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…obe tests
`npm_view_version_reads_the_registry_answer` flaked on ubuntu CI with
`None` instead of `Some("4.5.6")`, failing instantly rather than at the
10s bound. On Linux, `fs::write` of the fake `npm` script leaves a write
fd open briefly; a test on another thread that forks in that window
inherits the fd until its own exec, and `execve` of a file anyone holds
open for writing fails with ETXTBSY — which `npm_view_version` rightly
reports as unknown. macOS doesn't enforce this, so it never reproduced
locally.
Route every fake-npm write through a `write_executable` helper that
probe-spawns (and immediately kills) the script until exec succeeds,
including the hung-lookup script in the failure-modes test.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reorders the branch timeline footer's "…" overflow menu so it reads as a continuation of the button row:
As a result, "New code review" now sits above "Write note".
🤖 Generated with Claude Code