[PM-39357] Make it possible to go offline from pricing service#7867
Draft
justindbaur wants to merge 1 commit into
Draft
[PM-39357] Make it possible to go offline from pricing service#7867justindbaur wants to merge 1 commit into
justindbaur wants to merge 1 commit into
Conversation
justindbaur
added
the
t:misc
|
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| // Assert | ||
| Assert.Null(result); | ||
| } | ||
| var mockHttp = new MockHttpMessageHandler(); |
Comment on lines
+168
to
+171
| var httpClient = new HttpClient(mockHttp) | ||
| { | ||
| BaseAddress = new Uri("https://test.com/") | ||
| }; |
Comment on lines
+157
to
+163
| foreach (var remotePlan in remotePlans) | ||
| { | ||
| if (localPlans.All(local => local.Type != remotePlan.Type)) | ||
| { | ||
| failures.Add($"{remotePlan.Type}: present remotely, absent locally"); | ||
| } | ||
| } |
Comment on lines
+197
to
+203
| foreach (var remotePlan in remotePlans) | ||
| { | ||
| if (localPlans.All(local => local.Name != remotePlan.Name)) | ||
| { | ||
| failures.Add($"{remotePlan.Name}: present remotely, absent locally"); | ||
| } | ||
| } |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7867 +/- ##
==========================================
- Coverage 65.79% 60.55% -5.24%
==========================================
Files 2212 2219 +7
Lines 97922 99128 +1206
Branches 8836 8855 +19
==========================================
- Hits 64426 60028 -4398
- Misses 31287 36988 +5701
+ Partials 2209 2112 -97 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
justindbaur
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-39357
📔 Objective
Updated the DI registration of
IPricingClientto allow for anullpricing service url in settings in Development mode only. When the setting is null it will return an instance that does not need to reach out to the broader internet and will return local plan information. This information will eventually get stale from the real stuff but that is not a huge concern and can easily be updated later on.📸 Screenshots