Skip to content

removed curl and replaced healthcheck with wget#7858

Open
keithhubner wants to merge 5 commits into
mainfrom
SHOT-184-remove-curl-healthchecks
Open

removed curl and replaced healthcheck with wget#7858
keithhubner wants to merge 5 commits into
mainfrom
SHOT-184-remove-curl-healthchecks

Conversation

@keithhubner

Copy link
Copy Markdown
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/SHOT-184

📔 Objective

Remove curl from images

@keithhubner keithhubner added the ai-review Request a Claude code review label Jun 24, 2026
@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR removes the curl package from 11 service Dockerfiles and the Nginx image, replacing HEALTHCHECK probes with BusyBox wget, reducing the installed package surface. The flag mappings preserve the original semantics: curl -f (fail on HTTP 4xx/5xx) is matched by BusyBox wget, which also exits non-zero on server error responses, and curl --insecure maps correctly to wget --no-check-certificate for the Nginx HTTPS-then-HTTP fallback chain. BusyBox wget and all flags used (--quiet, --tries=1, --output-document, --no-check-certificate) are available by default in the dotnet/aspnet:*-alpine and nginx:*-alpine base images.

Code Review Details

No findings. The change is well-scoped and consistent across all modified Dockerfiles. Remaining curl references in util/Setup/Dockerfile and util/SeederApi/Dockerfile are intentionally out of scope for this healthcheck cleanup.

@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.21%. Comparing base (3fe137c) to head (ee32942).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7858      +/-   ##
==========================================
- Coverage   61.21%   61.21%   -0.01%     
==========================================
  Files        2217     2217              
  Lines       98042    98042              
  Branches     8846     8846              
==========================================
- Hits        60014    60013       -1     
- Misses      35915    35916       +1     
  Partials     2113     2113              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@keithhubner keithhubner added the t:tech-debt Change Type - Tech debt label Jun 24, 2026
@keithhubner keithhubner marked this pull request as ready for review June 24, 2026 15:32
@keithhubner keithhubner requested review from a team as code owners June 24, 2026 15:32
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review t:tech-debt Change Type - Tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants