[BRE-1935] Migrate workflow: cd.yml (Phase 2) - #105
Draft
AmyLGalles wants to merge 2 commits into
Draft
Conversation
Replaces the full PyPI publishing logic with a trigger-actions caller that dispatches to bitwarden/deploy's publish-passwordless-python workflow. Changes: - Removed all build, poetry, and PyPI publishing steps - Added workflow_dispatch trigger with tag input for manual dispatch - Kept release: [created] trigger for automatic releases - Uses bitwarden/gh-actions/trigger-actions to dispatch to deploy repo The actual build and publish logic now lives in: bitwarden/deploy/.github/workflows/publish-passwordless-python.yml This workflow can still be triggered manually from this repo via: gh workflow run cd.yml --repo bitwarden/passwordless-python -f tag=v1.2.3 Or automatically when a release is created in this repo. This completes Phase 2 (finalize-source) of the BRE-1935 migration pattern.
Author
|
@claude review this |
Security fix:
- Changed workflow-level permissions from 'deployments: write' to '{}'
- Grant minimum permissions per-job only (best practice)
Functionality fix:
- Added required Azure credential inputs to trigger-actions call
- Added id-token: write permission for Azure OIDC federation
The trigger-actions composite action requires Azure credentials to
retrieve GitHub App secrets from KeyVault for cross-repo deployment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is Phase 2 (finalize-source) of the BRE-1935 migration for the
cd.ymlworkflow.Phase 1 (already merged in bitwarden/deploy): https://github.com/bitwarden/deploy/pull/275
What This Does
Converts the source repo's
cd.ymlfrom a full PyPI publishing workflow to a lightweight trigger-actions caller that dispatches to the centralized workflow inbitwarden/deploy.Changes
Before (47 lines)
release: [created]After (31 lines)
release: [created]trigger (automatic on release)workflow_dispatchtrigger (manual dispatch option)Developer Experience
Automatic (unchanged)
When a release is created in this repo, the workflow automatically triggers and dispatches to bitwarden/deploy for publishing.
Manual Dispatch (new)
Developers can now manually trigger publishing from this repo:
Actual Publishing Logic
Now lives in:
bitwarden/deploy/.github/workflows/publish-passwordless-python.ymlMigration Phases
Testing
After merge:
gh workflow run cd.yml -f tag=<test-tag>Documentation
No documentation references to
cd.ymlwere found in this repo.