Merged
Conversation
WASM bindings for RemoteClient via wasm-bindgen, with a browser-based demo using Alpine.js + Tailwind. Includes a web-sys WebSocket ProxyClient implementation, localStorage-backed identity and session storage, and a clean JS API wrapper (remote-access.js).
- Remove unused isConnected getter from Rust and JS layers - Remove dead notification_rx field, unused pub use, unused web-sys features - Clear oneshot WebSocket handlers after open resolves - Add comment explaining std::sync::Mutex usage in JS callbacks - Cap activity log at 100 entries to prevent unbounded growth - Cache credentialEntries instead of recomputing on each render - Warn on corrupt localStorage instead of silently resetting
|
New Issues (1)Checkmarx found the following issues in this Pull Request
|
Split WasmRemoteClient.connect(token, session) into individual methods (connect, pairWithHandshake, pairWithPsk, loadCachedConnection) that map 1:1 to RemoteClient. PSK vs rendezvous branching now lives in the JS RemoteAccessClient class instead of duplicating orchestration logic in Rust.
Extract connection listing and clearing from WasmRemoteClient methods into free #[wasm_bindgen] functions in storage.rs. They only need an identity name, not a connected client. Also extract #withFreshConnection helper in JS to deduplicate the connect/cleanup pattern.
Replace bun references with npm in build.sh and README, remove bun.lock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
📔 Objective
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes