feat(EditorMentionMenu): add item.color forwarded to leading Avatar#35
Open
IgorShevchik wants to merge 1 commit into
Open
feat(EditorMentionMenu): add item.color forwarded to leading Avatar#35IgorShevchik wants to merge 1 commit into
IgorShevchik wants to merge 1 commit into
Conversation
IgorShevchik
force-pushed
the
feat/editor-mention-menu-avatar-color
branch
from
7712643 to
6d2d991
Compare
Adds `color?: AvatarProps['color']` to `EditorMentionMenuItem` and forwards it as the default `color` to the item's leading `B24Avatar`. Explicit `item.avatar.color` still wins, since the avatar object is spread after `color` in the `h(B24Avatar, ...)` call. No host-level color is introduced — the new prop only tints the inner Avatar. Especially useful for @mention UX where roles, statuses, or other per-user signals are conveyed by avatar tint. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
IgorShevchik
force-pushed
the
feat/editor-mention-menu-avatar-color
branch
from
6d2d991 to
3c0923b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
color?: AvatarProps['color']toEditorMentionMenuItem.colorto the item's leadingB24Avatar. Explicititem.avatar.colorstill wins, since the avatar object is spread aftercolorin theh(B24Avatar, ...)call.src/theme/editor-mention-menu.tsis untouched. The new prop only tints the inner Avatar.Follow-up to #24 (Avatar/AvatarGroup
color), #27 (User), #28 (ChatMessage), #29 (Alert), #30 (Toast), #31 (Timeline), #32 (NavigationMenu), #33 (Tabs), #34 (CommandPalette).Test plan
pnpm run lint/pnpm run typecheckpass (no test file exists forEditorMentionMenu— it renders inside the editor only)colortints the mention-menu avataritem.avatar.coloroverrides the cascade🤖 Generated with Claude Code