[BWS] use coingecko days=max for all-time fiat rates - #4223
Open
msalcala11 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
V4 fiat-rate requests without a
daysparameter recently stopped returning the expected historical data. The app relies on this request to populate the 3M, 1Y, 5Y, and ALL time views, so those views are currently broken.BWS was translating an omitted
daysparameter intodays=100000for CoinGecko. This PR replacesdays=100000with CoinGecko’s supporteddays=maxvalue.Changelog
daysparameter into CoinGecko’sdays=maxvalue.days=100000results are not reused.daysrequests.Testing Notes
From
packages/bitcore-wallet-service, run all integration tests:npm run compile npx mocha 'ts_build/test/integration/**/*.test.js'MongoDB must be available at
localhost:27017.Test the routes used by the app to fetch all-time rate data:
The response should contain all-time history. BWS should send
days=maxandinterval=dailyto CoinGecko.Checklist